Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[sanitizer][asan][win] Intercept _strdup on windows instead of strdup.

Authored by barcharcraz on May 4 2023, 10:55 AM.



Intercept _strdup on windows, instead of strdup (which doesn't exist).

I'm not a committer yet, so I'll need someone to merge this for me.

(update: adding llvm-commits, which I didn't know I needed to add manually)

Diff Detail

Event Timeline

barcharcraz created this revision.May 4 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2023, 10:55 AM
Herald added a subscriber: Enna1. · View Herald Transcript
barcharcraz published this revision for review.May 4 2023, 11:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2023, 11:11 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added inline comments.May 11 2023, 1:36 PM

can you move this to the and of the file?
so you don't need #if around ASAN_INTERCEPT_FUNC

barcharcraz marked an inline comment as done.
  • move the macro to the end of the file.
  • clang-format
vitalybuka accepted this revision.May 16 2023, 3:32 PM
This revision is now accepted and ready to land.May 16 2023, 3:32 PM
strega-nil accepted this revision.May 24 2023, 3:12 PM

Can someone commit this? It should be good to go and I don't have commit access (long term I will probably be requesting commit access)

barcharcraz edited the summary of this revision. (Show Details)Jul 5 2023, 12:25 PM
barcharcraz added a subscriber: llvm-commits.

I forgot to add llvm-commits as a subscriber here (I guess simply setting the repository field correctly is not enough), so it's been stuck on accepted for a while. I think this still applies cleanly though.

Could someone commit this?

barcharcraz closed this revision.Jul 19 2023, 4:29 PM

This was merged as 31263211c6a4ef454216f2edbf9b2083a4c1474d, but the magic words to close the revision were missing.