This is an archive of the discontinued LLVM Phabricator instance.

Differential D149728

[libc][DO NOT SUBMIT] Extend add_fp_unittest to handle hermetic tests.
Needs ReviewPublic

Authored by sivachandra on May 3 2023, 12:50 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This is for demonstration only.

Diff Detail

Event Timeline

sivachandra created this revision.May 3 2023, 12:50 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 3 2023, 12:50 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.May 3 2023, 12:50 AM
sivachandra mentioned this in D149705: [libc] Enable the 'stdlib' unit tests to be hermetic.May 3 2023, 12:52 AM
Harbormaster completed remote builds in B229624: Diff 518995.May 3 2023, 12:56 AM

Revision Contents

PathSize
libc/
test/
src/
12 lines

Diff 518995

libc/test/src/CMakeLists.txt

function(add_fp_unittest name) function(add_fp_unittest name)
cmake_parse_arguments( cmake_parse_arguments(
"MATH_UNITTEST" "MATH_UNITTEST"
"NEED_MPFR" # Optional arguments "NEED_MPFR;HERMETIC_TEST_ONLY" # Optional arguments
"" # Single value arguments "" # Single value arguments
"LINK_LIBRARIES" # Multi-value arguments "LINK_LIBRARIES" # Multi-value arguments
${ARGN} ${ARGN}
) )
if(MATH_UNITTEST_NEED_MPFR) if(MATH_UNITTEST_NEED_MPFR)
if(NOT LIBC_TESTS_CAN_USE_MPFR) if(NOT LIBC_TESTS_CAN_USE_MPFR)
message("WARNING: Math test ${name} will be skipped as MPFR library is not available.") message("WARNING: Math test ${name} will be skipped as MPFR library is not available.")
return() return()
endif() endif()
endif() endif()
if(MATH_UNITTEST_HERMETIC_TEST_ONLY)
set(test_type HERMETIC_TEST_ONLY)
endif()
if(MATH_UNITTEST_NEED_MPFR) if(MATH_UNITTEST_NEED_MPFR)
if(MATH_UNITTEST_HERMETIC_TEST_ONLY)
message(FATAL "Hermetic math test cannot require MPFR.")
endif()
set(test_type UNIT_TEST_ONLY)
list(APPEND MATH_UNITTEST_LINK_LIBRARIES libcMPFRWrapper libc_math_test_utils -lmpfr -lgmp) list(APPEND MATH_UNITTEST_LINK_LIBRARIES libcMPFRWrapper libc_math_test_utils -lmpfr -lgmp)
endif() endif()
list(APPEND MATH_UNITTEST_LINK_LIBRARIES LibcFPTestHelpers) list(APPEND MATH_UNITTEST_LINK_LIBRARIES LibcFPTestHelpers)
add_libc_unittest( add_libc_test(
${name} ${name}
${test_type}
LINK_LIBRARIES "${MATH_UNITTEST_LINK_LIBRARIES}" LINK_LIBRARIES "${MATH_UNITTEST_LINK_LIBRARIES}"
"${MATH_UNITTEST_UNPARSED_ARGUMENTS}" "${MATH_UNITTEST_UNPARSED_ARGUMENTS}"
) )
endfunction(add_fp_unittest) endfunction(add_fp_unittest)
add_subdirectory(__support) add_subdirectory(__support)
add_subdirectory(ctype) add_subdirectory(ctype)
add_subdirectory(errno) add_subdirectory(errno)
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines