Page MenuHomePhabricator

[MCMachOStreamer] Properly reset CreatedADWARFSection
AbandonedPublic

Authored by loladiro on Nov 24 2015, 11:12 AM.

Details

Summary

Without this, a PassManager can not be reused for multiple modules in a row when emitting debug info on MachO.

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 41068.Nov 24 2015, 11:12 AM
loladiro retitled this revision from to [MCMachOStreamer] Properly reset CreatedADWARFSection.
loladiro updated this object.
loladiro added a reviewer: rafael.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: llvm-commits.
yaron.keren accepted this revision.Nov 24 2015, 1:35 PM
yaron.keren added a reviewer: yaron.keren.

We have been fixed such bugs before, usually when a data member is added to one of the Streamers, so LGTM.

This revision is now accepted and ready to land.Nov 24 2015, 1:35 PM
rafael accepted this revision.Nov 24 2015, 2:47 PM
rafael edited edge metadata.

LGTM

loladiro added a subscriber: bogner.Dec 4 2015, 4:55 PM

Turns out @bogner already committed this in the meantime. I'll still go ahead and add a test based on D14965.

loladiro abandoned this revision.Dec 4 2015, 4:55 PM