[libc++][PSTL] Implement std::fill{,_n}

[philnik]

Try to fix CI

[ldionne]

libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill.pass.cpp

42

here and below.

libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill_n.pass.cpp

17

Wrong signature!

42

[philnik]

Address comments

libcxx/include/CMakeLists.txt

set(files
   __algorithm/partial_sort.h
   __algorithm/partial_sort_copy.h
   __algorithm/partition.h
   __algorithm/partition_copy.h
   __algorithm/partition_point.h
   __algorithm/pop_heap.h
   __algorithm/prev_permutation.h
   __algorithm/pstl_any_all_none_of.h
+  __algorithm/pstl_fill.h
   __algorithm/pstl_find.h
   __algorithm/pstl_for_each.h
   __algorithm/push_heap.h
   __algorithm/ranges_adjacent_find.h
   __algorithm/ranges_all_of.h
   __algorithm/ranges_any_of.h
   __algorithm/ranges_binary_search.h
   __algorithm/ranges_clamp.h

libcxx/include/__algorithm/pstl_fill.h

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef _LIBCPP___ALGORITHM_PSTL_FILL_H
+#define _LIBCPP___ALGORITHM_PSTL_FILL_H
+
+#include <__algorithm/fill.h>
+#include <__config>
+#include <__iterator/iterator_traits.h>
+#include <__pstl/internal/parallel_impl.h>
+#include <__pstl/internal/unseq_backend_simd.h>
+#include <__type_traits/is_execution_policy.h>
+#include <__utility/terminate_on_exception.h>
+
+#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
+#  pragma GCC system_header
+#endif
+
+#if _LIBCPP_STD_VER >= 17
+
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+template <class _ExecutionPolicy,
+          class _ForwardIterator,
+          class _Tp,
+          enable_if_t<is_execution_policy_v<__remove_cvref_t<_ExecutionPolicy>>, int> = 0>
+_LIBCPP_HIDE_FROM_ABI void
+fill(_ExecutionPolicy&& __policy, _ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) {
+  if constexpr (__is_parallel_execution_policy_v<_ExecutionPolicy> &&
+                __is_cpp17_random_access_iterator<_ForwardIterator>::value) {
+    std::__terminate_on_exception([&] {
+      __pstl::__par_backend::__parallel_for(
+          __pstl::__internal::__par_backend_tag{},
+          __policy,
+          __first,
+          __last,
+          [&__policy, &__value](_ForwardIterator __brick_first, _ForwardIterator __brick_last) {
+            std::fill(std::__remove_parallel_policy(__policy), __brick_first, __brick_last, __value);
+          });
+    });
+  } else if constexpr (__is_unsequenced_execution_policy_v<_ExecutionPolicy> &&
+                       __is_cpp17_random_access_iterator<_ForwardIterator>::value) {
+    __pstl::__unseq_backend::__simd_fill_n(__first, __last - __first, __value);
+  } else {
+    std::fill(__first, __last, __value);
+  }
+}
+
+template <class _ExecutionPolicy,
+          class _ForwardIterator,
+          class _SizeT,
+          class _Tp,
+          enable_if_t<is_execution_policy_v<__remove_cvref_t<_ExecutionPolicy>>, int> = 0>
+_LIBCPP_HIDE_FROM_ABI void
+fill_n(_ExecutionPolicy&& __policy, _ForwardIterator __first, _SizeT __n, const _Tp& __value) {
+  if constexpr (__is_cpp17_random_access_iterator<_ForwardIterator>::value)
+    std::fill(__policy, __first, __first + __n, __value);
+  else
+    std::fill_n(__first, __n, __value);
+}
+
+_LIBCPP_END_NAMESPACE_STD
+
+#endif // _LIBCPP_STD_VER >= 17
+
+#endif // _LIBCPP___ALGORITHM_PSTL_FILL_H

libcxx/include/__pstl/internal/algorithm_impl.h

else if (__x - __nth < 0) {
         iter_swap(__nth, __x);
       }
       __first = __x;
     }
   } while (__x != __nth);
 }
 
 //------------------------------------------------------------------------
-// fill, fill_n
-//------------------------------------------------------------------------
-template <class _RandomAccessIterator, class _Tp>
-void __brick_fill(_RandomAccessIterator __first,
-                  _RandomAccessIterator __last,
-                  const _Tp& __value,
-                  /* __is_vector = */ std::true_type) noexcept {
-  __unseq_backend::__simd_fill_n(__first, __last - __first, __value);
-}
-
-template <class _ForwardIterator, class _Tp>
-void __brick_fill(_ForwardIterator __first,
-                  _ForwardIterator __last,
-                  const _Tp& __value,
-                  /* __is_vector = */ std::false_type) noexcept {
-  std::fill(__first, __last, __value);
-}
-
-template <class _Tag, class _ExecutionPolicy, class _ForwardIterator, class _Tp>
-void __pattern_fill(
-    _Tag, _ExecutionPolicy&&, _ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) noexcept {
-  __internal::__brick_fill(__first, __last, __value, typename _Tag::__is_vector{});
-}
-
-template <class _IsVector, class _ExecutionPolicy, class _RandomAccessIterator, class _Tp>
-_RandomAccessIterator __pattern_fill(
-    __parallel_tag<_IsVector> __tag,
-    _ExecutionPolicy&& __exec,
-    _RandomAccessIterator __first,
-    _RandomAccessIterator __last,
-    const _Tp& __value) {
-  using __backend_tag = typename decltype(__tag)::__backend_tag;
-
-  return __internal::__except_handler([&__exec, __first, __last, &__value]() {
-    __par_backend::__parallel_for(
-        __backend_tag{},
-        std::forward<_ExecutionPolicy>(__exec),
-        __first,
-        __last,
-        [&__value](_RandomAccessIterator __begin, _RandomAccessIterator __end) {
-          __internal::__brick_fill(__begin, __end, __value, _IsVector{});
-        });
-    return __last;
-  });
-}
-
-template <class _RandomAccessIterator, class _Size, class _Tp>
-_RandomAccessIterator
-__brick_fill_n(_RandomAccessIterator __first,
-               _Size __count,
-               const _Tp& __value,
-               /* __is_vector = */ std::true_type) noexcept {
-  return __unseq_backend::__simd_fill_n(__first, __count, __value);
-}
-
-template <class _OutputIterator, class _Size, class _Tp>
-_OutputIterator __brick_fill_n(
-    _OutputIterator __first, _Size __count, const _Tp& __value, /* __is_vector = */ std::false_type) noexcept {
-  return std::fill_n(__first, __count, __value);
-}
-
-template <class _Tag, class _ExecutionPolicy, class _OutputIterator, class _Size, class _Tp>
-_OutputIterator
-__pattern_fill_n(_Tag, _ExecutionPolicy&&, _OutputIterator __first, _Size __count, const _Tp& __value) noexcept {
-  return __internal::__brick_fill_n(__first, __count, __value, typename _Tag::__is_vector{});
-}
-
-template <class _IsVector, class _ExecutionPolicy, class _RandomAccessIterator, class _Size, class _Tp>
-_RandomAccessIterator __pattern_fill_n(
-    __parallel_tag<_IsVector> __tag,
-    _ExecutionPolicy&& __exec,
-    _RandomAccessIterator __first,
-    _Size __count,
-    const _Tp& __value) {
-  return __internal::__pattern_fill(__tag, std::forward<_ExecutionPolicy>(__exec), __first, __first + __count, __value);
-}
-
-//------------------------------------------------------------------------
 // generate, generate_n
 //------------------------------------------------------------------------
 template <class _RandomAccessIterator, class _Generator>
 void __brick_generate(_RandomAccessIterator __first,
                       _RandomAccessIterator __last,
                       _Generator __g,
                       /* is_vector = */ std::true_type) noexcept {
   __unseq_backend::__simd_generate_n(__first, __last - __first, __g);

libcxx/include/__pstl/internal/glue_algorithm_defs.h

 __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardIterator2> replace_copy(
     _ExecutionPolicy&& __exec,
     _ForwardIterator1 __first,
     _ForwardIterator1 __last,
     _ForwardIterator2 __result,
     const _Tp& __old_value,
     const _Tp& __new_value);
 
-// [alg.fill]
-
-template <class _ExecutionPolicy, class _ForwardIterator, class _Tp>
-__pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, void>
-fill(_ExecutionPolicy&& __exec, _ForwardIterator __first, _ForwardIterator __last, const _Tp& __value);
-
-template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Tp>
-__pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardIterator>
-fill_n(_ExecutionPolicy&& __exec, _ForwardIterator __first, _Size __count, const _Tp& __value);
-
 // [alg.generate]
 template <class _ExecutionPolicy, class _ForwardIterator, class _Generator>
 __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, void>
 generate(_ExecutionPolicy&& __exec, _ForwardIterator __first, _ForwardIterator __last, _Generator __g);
 
 template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Generator>
 __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardIterator>
 generate_n(_ExecutionPolicy&& __exec, _ForwardIterator __first, _Size count, _Generator __g);

libcxx/include/__pstl/internal/glue_algorithm_impl.h

return std::replace_copy_if(
       std::forward<_ExecutionPolicy>(__exec),
       __first,
       __last,
       __result,
       __pstl::__internal::__equal_value<_Tp>(__old_value),
       __new_value);
 }
 
-// [alg.fill]
-
-template <class _ExecutionPolicy, class _ForwardIterator, class _Tp>
-__pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, void>
-fill(_ExecutionPolicy&& __exec, _ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) {
-  auto __dispatch_tag = __pstl::__internal::__select_backend(__exec, __first);
-
-  __pstl::__internal::__pattern_fill(__dispatch_tag, std::forward<_ExecutionPolicy>(__exec), __first, __last, __value);
-}
-
-template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Tp>
-__pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, _ForwardIterator>
-fill_n(_ExecutionPolicy&& __exec, _ForwardIterator __first, _Size __count, const _Tp& __value) {
-  if (__count <= 0)
-    return __first;
-
-  auto __dispatch_tag = __pstl::__internal::__select_backend(__exec, __first);
-
-  return __pstl::__internal::__pattern_fill_n(
-      __dispatch_tag, std::forward<_ExecutionPolicy>(__exec), __first, __count, __value);
-}
-
 // [alg.generate]
 template <class _ExecutionPolicy, class _ForwardIterator, class _Generator>
 __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, void>
 generate(_ExecutionPolicy&& __exec, _ForwardIterator __first, _ForwardIterator __last, _Generator __g) {
   auto __dispatch_tag = __pstl::__internal::__select_backend(__exec, __first);
 
   __pstl::__internal::__pattern_generate(__dispatch_tag, std::forward<_ExecutionPolicy>(__exec), __first, __last, __g);
 }

libcxx/include/algorithm

 #include <__algorithm/transform.h>
 #include <__algorithm/unique.h>
 #include <__algorithm/unique_copy.h>
 #include <__algorithm/unwrap_iter.h>
 #include <__algorithm/upper_bound.h>
 
 #ifdef _LIBCPP_HAS_PARALLEL_ALGORITHMS
 #  include <__algorithm/pstl_any_all_none_of.h>
+#  include <__algorithm/pstl_fill.h>
 #  include <__algorithm/pstl_find.h>
 #  include <__algorithm/pstl_for_each.h>
 #endif
 
 // standard-mandated includes
 
 // [algorithm.syn]
 #include <initializer_list>

libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// <algorithm>
+
+// UNSUPPORTED: c++03, c++11, c++14
+
+// REQUIRES: with-pstl
+
+// template<class ExecutionPolicy, class ForwardIterator, class T>
+//   void fill(ExecutionPolicy&& exec,
+//             ForwardIterator first, ForwardIterator last, const T& value);
+
+#include <algorithm>
+#include <cassert>
+#include <vector>
+
+#include "test_macros.h"
+#include "test_execution_policies.h"
+#include "test_iterators.h"
+
+EXECUTION_POLICY_SFINAE_TEST(fill);
+
+static_assert(sfinae_test_fill<int, int*, int*, bool (*)(int)>);
+static_assert(!sfinae_test_fill<std::execution::parallel_policy, int*, int*, int>);
+
+template <class Iter>
+struct Test {
+  template <class Policy>
+  void operator()(Policy&& policy) {
+    { // simple test
+      int a[4];
+      std::fill(policy, Iter(std::begin(a)), Iter(std::end(a)), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that an empty range works
+      int a[1] = {2};
+      std::fill(policy, Iter(std::begin(a)), Iter(std::begin(a)), 33);
+      assert(a[0] == 2);
+    }
+    { // check that a one-element range works
+      int a[1];
+      std::fill(policy, Iter(std::begin(a)), Iter(std::end(a)), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that a two-element range works
+      int a[2];
+      std::fill(policy, Iter(std::begin(a)), Iter(std::end(a)), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that a large range works
+      std::vector<int> a(234, 2);
+      std::fill(policy, Iter(std::data(a)), Iter(std::data(a) + std::size(a)), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+  }
+};
+
+struct ThrowOnCopy {
+  ThrowOnCopy& operator=(const ThrowOnCopy&) { throw int{}; }
+};
+
+int main(int, char**) {
+  types::for_each(types::forward_iterator_list<int*>{}, TestIteratorWithPolicies<Test>{});
+
+#ifndef TEST_HAS_NO_EXCEPTIONS
+  std::set_terminate(terminate_successful);
+  ThrowOnCopy a[2];
+  try {
+    (void)std::fill(std::execution::par, std::begin(a), std::end(a), ThrowOnCopy{});
+  } catch (int) {
+    assert(false);
+  }
+#endif
+
+  return 0;
+}

libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill_n.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// <algorithm>
+
+// UNSUPPORTED: c++03, c++11, c++14
+
+// REQUIRES: with-pstl
+
+// template<class ExecutionPolicy, class ForwardIterator, class Size, class T>
+//   ForwardIterator fill_n(ExecutionPolicy&& exec,
+//                          ForwardIterator first, Size n, const T& value);
+
+#include <algorithm>
+#include <cassert>
+#include <vector>
+
+#include "test_macros.h"
+#include "test_execution_policies.h"
+#include "test_iterators.h"
+
+EXECUTION_POLICY_SFINAE_TEST(fill_n);
+
+static_assert(sfinae_test_fill_n<int, int*, int*, bool (*)(int)>);
+static_assert(!sfinae_test_fill_n<std::execution::parallel_policy, int*, int*, int>);
+
+template <class Iter>
+struct Test {
+  template <class Policy>
+  void operator()(Policy&& policy) {
+    { // simple test
+      int a[4];
+      std::fill_n(policy, Iter(std::begin(a)), std::size(a), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that an empty range works
+      int a[1] = {2};
+      std::fill_n(policy, Iter(std::begin(a)), 0, 33);
+      assert(a[0] == 2);
+    }
+    { // check that a one-element range works
+      int a[1];
+      std::fill_n(policy, Iter(std::begin(a)), std::size(a), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that a two-element range works
+      int a[2];
+      std::fill_n(policy, Iter(std::begin(a)), std::size(a), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+    { // check that a large range works
+      std::vector<int> a(234, 2);
+      std::fill_n(policy, Iter(std::data(a)), std::size(a), 33);
+      assert(std::all_of(std::begin(a), std::end(a), [](int i) { return i == 33; }));
+    }
+  }
+};
+
+struct ThrowOnCopy {
+  ThrowOnCopy& operator=(const ThrowOnCopy&) { throw int{}; }
+};
+
+int main(int, char**) {
+  types::for_each(types::forward_iterator_list<int*>{}, TestIteratorWithPolicies<Test>{});
+
+#ifndef TEST_HAS_NO_EXCEPTIONS
+  std::set_terminate(terminate_successful);
+  ThrowOnCopy a[2];
+  try {
+    (void)std::fill_n(std::execution::par, std::begin(a), std::size(a), ThrowOnCopy{});
+  } catch (int) {
+    assert(false);
+  }
+#endif
+
+  return 0;
+}