This is an archive of the discontinued LLVM Phabricator instance.

[lldb/crashlog] Fix json module loading issue
ClosedPublic

Authored by mib on Apr 28 2023, 12:43 PM.

Details

Summary

In 27f27d15f6c9, we added a new way to use textual (JSON) object files
and symbol files with the interactive crashlog command, using the
inlined symbols from the crash report.

However, there was a missing piece after successfully adding the textual
module to the target, we didn't mark it as available causing the module
loading to exit early.

This patch addresses that issue by marking the module as available when
added successfully to the target.

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

Diff Detail

Event Timeline

mib created this revision.Apr 28 2023, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 12:43 PM
mib requested review of this revision.Apr 28 2023, 12:43 PM
This revision is now accepted and ready to land.Apr 28 2023, 12:46 PM
This revision was landed with ongoing or failed builds.Apr 28 2023, 12:51 PM
This revision was automatically updated to reflect the committed changes.