This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Adjust D_LIBCPP_ENABLE_ASSERTIONS defines in exception_guard tests
ClosedPublic

Authored by ldionne on Apr 19 2023, 12:58 PM.

Details

Summary

For the assert.FOO.pass.cpp test, we should be passing _LIBCPP_ENABLE_ASSERTIONS=1
for consistency, even though -D_LIBCPP_ENABLE_ASSERTIONS is equivalent.

For the other test, we shouldn't be forcing assertions to be enabled,
since we already have a CI job that enables assertions by default and
will do the right thing.

Diff Detail

Event Timeline

ldionne created this revision.Apr 19 2023, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 12:58 PM
ldionne requested review of this revision.Apr 19 2023, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 12:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Apr 20 2023, 4:48 AM
This revision is now accepted and ready to land.Apr 20 2023, 4:48 AM
This revision was landed with ongoing or failed builds.Apr 20 2023, 4:49 AM
This revision was automatically updated to reflect the committed changes.