This is an archive of the discontinued LLVM Phabricator instance.

Differential D148727

[fuzzer][test] Disable big-file-copy.test for everything but macOS
ClosedPublic

Authored by rsundahl on Apr 19 2023, 9:47 AM.

Details

Reviewers
yln
thetruestblue
wrotki
Commits
rGb62c39f9ef2a: [fuzzer][test] Disable big-file-copy.test for everything but macOS
Summary

This test is heavy on test resources and involves moving a large 2GB+ file
across an ssh connection when testing on remote devices. Exclude all tests
except for macOS testing (on host). Remote device testing for macOS may
eventually cause a problem on macOS as well w/o better handling of tests
that require more resource/time than we currently handle.

Introduced by:
    https://reviews.llvm.org/D146189
Subsequent exclusion of all but darwin by:
    https://reviews.llvm.org/D147094
Subsequent exclusion of tvOS and watchOS by:
    https://reviews.llvm.org/D147502
Subsequent exclusion of all but macOS...

rdar://107570309

Diff Detail

Event Timeline

rsundahl created this revision.Apr 19 2023, 9:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 9:47 AM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Apr 19 2023, 9:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 9:47 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl added reviewers: yln, thetruestblue, wrotki.Apr 19 2023, 9:48 AM
Harbormaster completed remote builds in B226636: Diff 515002.Apr 19 2023, 10:10 AM
rsundahl updated this revision to Diff 515381.Apr 20 2023, 10:24 AM

Slightly more readable way to describe the situation

rsundahl added a comment.Apr 20 2023, 10:29 AM

@yln @wrotki @thetruestblue please review/approve so we can unblock CI.

Harbormaster completed remote builds in B226910: Diff 515381.Apr 20 2023, 11:17 AM
thetruestblue accepted this revision.Apr 20 2023, 12:13 PM
This revision is now accepted and ready to land.Apr 20 2023, 12:13 PM
yln accepted this revision.Apr 20 2023, 12:15 PM
This revision was landed with ongoing or failed builds.Apr 20 2023, 12:19 PM
Closed by commit rGb62c39f9ef2a: [fuzzer][test] Disable big-file-copy.test for everything but macOS (authored by rsundahl). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsundahl added a commit: rGb62c39f9ef2a: [fuzzer][test] Disable big-file-copy.test for everything but macOS.

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
2 lines

Diff 515432

compiler-rt/test/fuzzer/big-file-copy.test

REQUIRES: darwin REQUIRES: darwin
UNSUPPORTED: tvos || watchos UNSUPPORTED: ios
RUN: %cpp_compiler %S/BigFileCopy.cpp -o %t RUN: %cpp_compiler %S/BigFileCopy.cpp -o %t
RUN: %run %t -runs=1 -rss_limit_mb=4096 2>big-file-out.txt; result=$? RUN: %run %t -runs=1 -rss_limit_mb=4096 2>big-file-out.txt; result=$?
RUN: %run rm -f big-file.txt big-file-out.txt RUN: %run rm -f big-file.txt big-file-out.txt
RUN: (exit $result) RUN: (exit $result)