This is an archive of the discontinued LLVM Phabricator instance.

Differential D148448

mdspan/extents: Update transitive include files
AbandonedPublic

Authored by crtrott on Apr 15 2023, 8:19 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

mdspan/extents: fix issues reported by CI

fixes transitive includes and ABI hiding of interface.

Diff Detail

Unit TestsFailed

TimeTest
7,180 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
3,840 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp

Event Timeline

crtrott created this revision.Apr 15 2023, 8:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 8:19 PM
crtrott requested review of this revision.Apr 15 2023, 8:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 8:19 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
crtrott abandoned this revision.Apr 15 2023, 8:21 PM

Sorry this was unintentional

crtrott reclaimed this revision.Apr 15 2023, 8:22 PM

Hm trying to learn how to close this ...

crtrott abandoned this revision.Apr 15 2023, 8:24 PM

Hm how do I close this thing?

Harbormaster completed remote builds in B225889: Diff 513959.Apr 15 2023, 8:43 PM
philnik added a subscriber: philnik.Apr 15 2023, 8:50 PM
In D148448#4271693, @crtrott wrote:

Hm how do I close this thing?

Abandoning is correct when you don't plan to land this.

crtrott added a parent revision: D148067: [libcxx] Add mdspan/extents.Apr 17 2023, 11:58 AM
crtrott reclaimed this revision.Apr 17 2023, 12:01 PM

I gonna try see if this does what I want with the previous revision 148067 (i.e. its included in that). And check that tests actually pass.

crtrott updated this revision to Diff 514450.Apr 17 2023, 4:24 PM

mdspan/extents: address clang_tidy errors reported in CI

Harbormaster completed remote builds in B226255: Diff 514450.Apr 17 2023, 4:31 PM
crtrott updated this revision to Diff 514455.Apr 17 2023, 4:44 PM
crtrott edited the summary of this revision. (Show Details)

mdspan/extents: fix issues reported by CI

fixes transitive includes and ABI hiding of interface.

Harbormaster completed remote builds in B226258: Diff 514455.Apr 17 2023, 5:35 PM
crtrott updated this revision to Diff 514483.Apr 17 2023, 5:36 PM

Fix another ABI hiding issue reported by CI

crtrott mentioned this in D148067: [libcxx] Add mdspan/extents.Apr 17 2023, 6:22 PM
Harbormaster completed remote builds in B226280: Diff 514483.Apr 17 2023, 7:12 PM
crtrott abandoned this revision.Apr 18 2023, 7:15 AM

Included in D148067 now.

Revision Contents

PathSize
libcxx/
test/
libcxx/
transitive_includes/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines

Diff 513959

libcxx/test/libcxx/transitive_includes/cxx03.csv

Show First 20 Lines • Show All 526 Lines • ▼ Show 20 Lines
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map type_traits map type_traits
map utility map utility
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory atomic memory atomic
memory compare memory compare
memory concepts memory concepts
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstdlib memory cstdlib
memory cstring memory cstring
memory initializer_list memory initializer_list
▲ Show 20 Lines • Show All 431 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx11.csv

Show First 20 Lines • Show All 526 Lines • ▼ Show 20 Lines
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map type_traits map type_traits
map utility map utility
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory atomic memory atomic
memory compare memory compare
memory concepts memory concepts
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstdlib memory cstdlib
memory cstring memory cstring
memory initializer_list memory initializer_list
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx14.csv

Show First 20 Lines • Show All 528 Lines • ▼ Show 20 Lines
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map type_traits map type_traits
map utility map utility
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory atomic memory atomic
memory compare memory compare
memory concepts memory concepts
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstdlib memory cstdlib
memory cstring memory cstring
memory initializer_list memory initializer_list
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx17.csv

Show First 20 Lines • Show All 528 Lines • ▼ Show 20 Lines
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map type_traits map type_traits
map utility map utility
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory atomic memory atomic
memory compare memory compare
memory concepts memory concepts
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstdlib memory cstdlib
memory cstring memory cstring
memory initializer_list memory initializer_list
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx20.csv

Show First 20 Lines • Show All 534 Lines • ▼ Show 20 Lines
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map type_traits map type_traits
map utility map utility
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory atomic memory atomic
memory compare memory compare
memory concepts memory concepts
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstdlib memory cstdlib
memory cstring memory cstring
memory initializer_list memory initializer_list
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b.csv

Show First 20 Lines • Show All 355 Lines • ▼ Show 20 Lines
map cstddef map cstddef
map initializer_list map initializer_list
map limits map limits
map new map new
map optional map optional
map stdexcept map stdexcept
map tuple map tuple
map version map version
mdspan cinttypes
mdspan cstddef
mdspan limits
mdspan span
memory compare memory compare
memory cstddef memory cstddef
memory cstdint memory cstdint
memory cstring memory cstring
memory initializer_list memory initializer_list
memory iosfwd memory iosfwd
memory limits memory limits
memory new memory new
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines