This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Temporariy dispatch region from `RegionBeg`
ClosedPublic

Authored by Chia-hungDuan on Apr 7 2023, 9:45 AM.

Details

Summary

In general, a region is located from region base and has size
RegionSize. However, some platforms may not support mapping from
region base. Before we have each platform implements their specific
MemMap to handle the offset. Temporarily dispatch the region from
RegionBeg instead.

Diff Detail

Event Timeline

Chia-hungDuan created this revision.Apr 7 2023, 9:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 9:45 AM
Chia-hungDuan requested review of this revision.Apr 7 2023, 9:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 9:45 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

@fabio-d Please help verify if this works on Fuchsia

cferris accepted this revision.Apr 7 2023, 1:23 PM

LGTM

This revision is now accepted and ready to land.Apr 7 2023, 1:23 PM
fabio-d accepted this revision.Apr 11 2023, 11:34 AM

I've tested that this CL fixes the regression introduced on Fuchsia by D146009

This revision was automatically updated to reflect the committed changes.

@Chia-hungDuan I think we can remove this workaround now that we have a more general solution in D148141. I've verified that reverting this CL does not break Fuchsia, so +2 for removing it from my side.