This is an archive of the discontinued LLVM Phabricator instance.

Differential D147742

[python] Enable bindings tests on Windows
Needs ReviewPublic

Authored by R2RT on Apr 6 2023, 1:56 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Unlike stated by removed comment, they do simply pass in my local enviroment.

In order to find necessary fixes (if any), CI has to run these tests.

Diff Detail

Event Timeline

R2RT created this revision.Apr 6 2023, 1:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 1:56 PM
R2RT requested review of this revision.Apr 6 2023, 1:56 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptApr 6 2023, 1:56 PM
Harbormaster completed remote builds in B224100: Diff 511519.Apr 6 2023, 3:27 PM
R2RT added a comment.Apr 7 2023, 12:13 AM

According to CI logs, these tests are still not run on Windows builder.
Line below, present in Debian's log, is missing.

[9746/10613] cd /var/lib/buildkite-agent/builds/llvm-project/clang/bindings/python && /usr/bin/cmake -E env CLANG_NO_DEFAULT_CONFIG=1 CLANG_LIBRARY_PATH=/var/lib/buildkite-agent/builds/llvm-project/build/lib /usr/bin/python3.9 -m unittest discover

Further investigation is needed.

Revision Contents

PathSize
clang/
bindings/
python/
tests/
6 lines

Diff 511519

clang/bindings/python/tests/CMakeLists.txt

Show All 22 Lines
# interception and will then fail. # interception and will then fail.
# We could use LD_PRELOAD/DYLD_INSERT_LIBRARIES but this isn't # We could use LD_PRELOAD/DYLD_INSERT_LIBRARIES but this isn't
# portable so its easier just to not run the tests when building # portable so its easier just to not run the tests when building
# with ASan. # with ASan.
if(NOT LLVM_USE_SANITIZER STREQUAL "") if(NOT LLVM_USE_SANITIZER STREQUAL "")
set(RUN_PYTHON_TESTS FALSE) set(RUN_PYTHON_TESTS FALSE)
endif() endif()
# Tests fail on Windows, and need someone knowledgeable to fix.
# It's not clear whether it's a test or a valid binding problem.
if(WIN32)
set(RUN_PYTHON_TESTS FALSE)
endif()
# The Python FFI interface is broken on AIX: https://bugs.python.org/issue38628. # The Python FFI interface is broken on AIX: https://bugs.python.org/issue38628.
if(${CMAKE_SYSTEM_NAME} MATCHES "AIX") if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
set(RUN_PYTHON_TESTS FALSE) set(RUN_PYTHON_TESTS FALSE)
endif() endif()
# AArch64, Hexagon, and Sparc have known test failures that need to be # AArch64, Hexagon, and Sparc have known test failures that need to be
# addressed. # addressed.
# SystemZ has broken Python/FFI interface: # SystemZ has broken Python/FFI interface:
Show All 9 Lines