Page MenuHomePhabricator

[Myriad]: insert -L paths into linker cmd only when they exist.
ClosedPublic

Authored by dougk on Nov 17 2015, 1:12 PM.

Diff Detail

Event Timeline

dougk updated this revision to Diff 40424.Nov 17 2015, 1:12 PM
dougk retitled this revision from to [Myriad]: insert -L paths into linker cmd only when they exist..
dougk updated this object.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
jyknight added inline comments.Nov 17 2015, 2:32 PM
lib/Driver/ToolChains.cpp
4319

Should check GCCInstallation.isValid() before doing any of this.

4324

addPathIfExists instead of if/push_back.

dougk updated this revision to Diff 40442.Nov 17 2015, 3:07 PM
dougk marked 2 inline comments as done.

changes per jyknight

jyknight accepted this revision.Nov 18 2015, 6:43 AM
jyknight edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2015, 6:43 AM
This revision was automatically updated to reflect the committed changes.