This is an archive of the discontinued LLVM Phabricator instance.

Differential D147249

[lldb] Replace deprecated CFPropertyListWriteToStream (NFC)
ClosedPublic

Authored by kastiglione on Mar 30 2023, 10:52 AM.

Details

Reviewers
JDevlieghere
Commits
rG80b476a902a8: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)
Summary

Replace CFPropertyListWriteToStream with its recommended replacement, CFPropertyListWrite.

Diff Detail

Event Timeline

kastiglione created this revision.Mar 30 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 10:52 AM
kastiglione requested review of this revision.Mar 30 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 10:52 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B222791: Diff 509729.Mar 30 2023, 10:56 AM
JDevlieghere accepted this revision.Mar 30 2023, 11:16 AM

LGTM

This revision is now accepted and ready to land.Mar 30 2023, 11:16 AM
Closed by commit rG80b476a902a8: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC) (authored by kastiglione). · Explain WhyMar 30 2023, 11:21 AM
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rG80b476a902a8: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC).

Revision Contents

PathSize
lldb/
source/
Host/
macosx/
cfcpp/
3 lines

Diff 509746

lldb/source/Host/macosx/cfcpp/CFCData.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
CFDataRef CFCData::Serialize(CFPropertyListRef plist, CFDataRef CFCData::Serialize(CFPropertyListRef plist,
CFPropertyListFormat format) { CFPropertyListFormat format) {
CFAllocatorRef alloc = kCFAllocatorDefault; CFAllocatorRef alloc = kCFAllocatorDefault;
reset(); reset();
CFCReleaser<CFWriteStreamRef> stream( CFCReleaser<CFWriteStreamRef> stream(
::CFWriteStreamCreateWithAllocatedBuffers(alloc, alloc)); ::CFWriteStreamCreateWithAllocatedBuffers(alloc, alloc));
::CFWriteStreamOpen(stream.get()); ::CFWriteStreamOpen(stream.get());
CFIndex len = CFIndex len = ::CFPropertyListWrite(plist, stream.get(), format, 0, nullptr);
::CFPropertyListWriteToStream(plist, stream.get(), format, NULL);
if (len > 0) if (len > 0)
reset((CFDataRef)::CFWriteStreamCopyProperty(stream.get(), reset((CFDataRef)::CFWriteStreamCopyProperty(stream.get(),
kCFStreamPropertyDataWritten)); kCFStreamPropertyDataWritten));
::CFWriteStreamClose(stream.get()); ::CFWriteStreamClose(stream.get());
return get(); return get();
} }