This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Systematically define a macro to check whether a feature is unavailable
ClosedPublic

Authored by ldionne on Mar 30 2023, 5:55 AM.

Details

Summary

Previously, we inconsistently defined whether a feature was unavailable
on a given deployment target. We would have availability attributes for
all features, but only some features had the equivalent of a _HAS_NO_FOO
macro in the form of the DISABLE_FTM___foo macros. Instead, systematically
define a _HAS_NO_FOO macro, which makes it easier to understand how to
add availability markup for a new platform.

Diff Detail

Event Timeline

ldionne created this revision.Mar 30 2023, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 5:55 AM
Herald added a subscriber: arichardson. · View Herald Transcript
ldionne requested review of this revision.Mar 30 2023, 5:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 5:55 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 509643.Mar 30 2023, 6:13 AM

Include verbose_abort in refactoring

ldionne updated this revision to Diff 509649.Mar 30 2023, 6:30 AM

Fix placement of attribute.

ldionne updated this revision to Diff 509726.Mar 30 2023, 10:48 AM

Fix CI issues

ldionne accepted this revision.Mar 30 2023, 12:17 PM
This revision is now accepted and ready to land.Mar 30 2023, 12:17 PM
This revision was landed with ongoing or failed builds.Mar 30 2023, 12:18 PM
This revision was automatically updated to reflect the committed changes.