This is an archive of the discontinued LLVM Phabricator instance.

Disable resize_tls_dynamic test for HWASan
ClosedPublic

Authored by thurston on Mar 28 2023, 1:08 PM.

Details

Summary

The test is not applicable because HWASan does not intercept __tls_get_addr.

This is pre-emptive cleanup, to get ready for Kirill's patch to enable sanitizer common tests for HWASan (https://reviews.llvm.org/D147067).

Note that there is an outstanding dynamic TLS bug for sanitizers - https://github.com/google/sanitizers/issues/1409

  • but that isn't applicable here due to the lack of interception.

Test: LIT_FILTER=resize_tls_dynamic ninja check-sanitizer

Diff Detail

Event Timeline

thurston created this revision.Mar 28 2023, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:08 PM
Herald added a subscriber: Enna1. · View Herald Transcript
thurston requested review of this revision.Mar 28 2023, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:08 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov accepted this revision.Mar 28 2023, 1:44 PM
This revision is now accepted and ready to land.Mar 28 2023, 1:44 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added inline comments.
compiler-rt/test/sanitizer_common/TestCases/Linux/resize_tls_dynamic.cpp
9

it should be XFAIL for HWASAN, as we likely will intercept this for HWASAN