Page MenuHomePhabricator

Assert in that we have exactly one of size..text and size.__text

Authored by paquette on Mar 21 2023, 2:38 PM.



Make sure that we only get one of these possible output formats to prevent duplicate data later in LNT. Also makes it clearer what the valid outputs can be.

Diff Detail

rT test-suite

Event Timeline

paquette created this revision.Mar 21 2023, 2:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 2:38 PM
paquette requested review of this revision.Mar 21 2023, 2:38 PM
azharudd accepted this revision.Mar 22 2023, 11:28 AM

One nit, LGTM otherwise. Thanks!


The output comes from llvm-size. Can we please update the comment to reflect that.

This revision is now accepted and ready to land.Mar 22 2023, 11:28 AM
paquette updated this revision to Diff 507459.Mar 22 2023, 11:54 AM

Addressing review feedback before pushing

This revision was landed with ongoing or failed builds.Mar 22 2023, 11:56 AM
This revision was automatically updated to reflect the committed changes.