Assert in codesize.py that we have exactly one of size..text and size.__text

[paquette]

Summary

Make sure that we only get one of these possible output formats to prevent duplicate data later in LNT. Also makes it clearer what the valid outputs can be.

[azharudd]

One nit, LGTM otherwise. Thanks!

litsupport/modules/codesize.py

40

The output comes from llvm-size. Can we please update the comment to reflect that.

[paquette]

Addressing review feedback before pushing

litsupport/modules/codesize.py

if os.path.exists(filename):
                     logging.info("Ignoring malformed output line: %s", line)
                     continue
                 if values[0] == 'Total':
                     continue
                 try:
                     name = values[0]
                     val = int(values[1])
                     metrics['size.%s' % name] = val
+                    # The text size output here comes from llvm-size.
+                    # Darwin and GNU produce differently-formatted output.
+                    # Check that we have exactly one of the valid outputs.
+                    assert not ('size.__text' in metrics and
+                                'size..text' in metrics), """Both 'size.__text'
+                                and 'size..text' present in metrics.
+                                Only one of them should exist."""
                 except ValueError:
                     logging.info("Ignoring malformed output line: %s", line)
 
     return metrics
 
 
 def mutatePlan(context, plan):
     plan.metric_collectors.append(_getCodeSize)