This is an archive of the discontinued LLVM Phabricator instance.

Differential D146476

[libc][obvious] remove currently unused types
ClosedPublic

Authored by michaelrj on Mar 20 2023, 5:21 PM.

Details

Reviewers
None
Commits
rG23ea2c4f4a92: [libc][obvious] remove currently unused types
Summary

Somehow having MBState and StructTmType in the definition for wchar was
causing test failures. This should fix those.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 20 2023, 5:21 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 20 2023, 5:21 PM
Herald added subscribers: libc-commits, mikhail.ramalho, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Mar 20 2023, 5:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2023, 5:23 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG23ea2c4f4a92: [libc][obvious] remove currently unused types (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG23ea2c4f4a92: [libc][obvious] remove currently unused types.
Harbormaster completed remote builds in B220586: Diff 506787.Mar 20 2023, 5:30 PM

Revision Contents

PathSize
libc/
spec/
1 line
2 lines

Diff 506788

libc/spec/spec.td

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
def ConstVoidPtr : ConstType<VoidPtr>; def ConstVoidPtr : ConstType<VoidPtr>;
def SizeTType : NamedType<"size_t">; def SizeTType : NamedType<"size_t">;
def SizeTPtr : PtrType<SizeTType>; def SizeTPtr : PtrType<SizeTType>;
def RestrictedSizeTPtr : RestrictedPtrType<SizeTType>; def RestrictedSizeTPtr : RestrictedPtrType<SizeTType>;
def WCharType : NamedType<"wchar_t">; def WCharType : NamedType<"wchar_t">;
def WIntType : NamedType<"wint_t">; def WIntType : NamedType<"wint_t">;
def MBStateType : NamedType<"mbstate_t">;
def LongDoublePtr : PtrType<LongDoubleType>; def LongDoublePtr : PtrType<LongDoubleType>;
def IntMaxTType : NamedType<"intmax_t">; def IntMaxTType : NamedType<"intmax_t">;
def UIntMaxTType : NamedType<"uintmax_t">; def UIntMaxTType : NamedType<"uintmax_t">;
def UInt16Type : NamedType<"uint16_t">; def UInt16Type : NamedType<"uint16_t">;
def UInt32Type : NamedType<"uint32_t">; def UInt32Type : NamedType<"uint32_t">;
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines

libc/spec/stdc.td

Show First 20 Lines • Show All 1,072 Lines • ▼ Show 20 Lines HeaderSpec WChar = HeaderSpec<
"wchar.h", "wchar.h",
[ // Macros [ // Macros
Macro<"WEOF">, Macro<"WEOF">,
], ],
[ //Types [ //Types
SizeTType, SizeTType,
WIntType, WIntType,
WCharType, WCharType,
MBStateType,
StructTmType,
], ],
[], // Enumerations [], // Enumerations
[ [
FunctionSpec< FunctionSpec<
"wctob", "wctob",
RetValSpec<IntType>, RetValSpec<IntType>,
[ArgSpec<WIntType>] [ArgSpec<WIntType>]
>, >,
Show All 21 Lines