This is an archive of the discontinued LLVM Phabricator instance.

[test][asan] Fix test on MacOS 12+
ClosedPublic

Authored by vitalybuka on Mar 10 2023, 9:46 AM.

Diff Detail

Event Timeline

vitalybuka created this revision.Mar 10 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 9:46 AM
Herald added a subscriber: Enna1. · View Herald Transcript
vitalybuka requested review of this revision.Mar 10 2023, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 9:46 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl accepted this revision.Mar 10 2023, 5:01 PM

LGTM. Could limit it to just Apple but shouldn't matter. Thank you.

compiler-rt/test/asan/TestCases/report_error_summary.cpp
10

We generally are using the pattern:

// Required for dyld macOS 12.0+
#if (__APPLE__)
__attribute__((weak))
#endif

at this line but this will work just as well.

This revision is now accepted and ready to land.Mar 10 2023, 5:01 PM
This revision was automatically updated to reflect the committed changes.