Page MenuHomePhabricator

Add ompt_event_task_switch event into OMPT/OpenMP
ClosedPublic

Authored by harald.servat on Nov 11 2015, 2:57 AM.

Details

Summary

The patch adds support for ompt_event_task_switch into LLVM/OpenMP. Note that the patch has also updated the signature of ompt_event_task_switch to ompt_task_pair_callback_t (rather than the previous ompt_task_switch_callback_t).

Diff Detail

Repository
rL LLVM

Event Timeline

harald.servat retitled this revision from to Add ompt_event_task_switch event into OMPT/OpenMP.
harald.servat updated this object.

Please update your patch in differential to include full diffs with "git diff -U999999 master"

The patches in kmp_tasking.c should use ifdefs

#if OMPT_SUPPORT && OMPT_TRACE

I've updated the patch according to John's request.

Also should this only be part of the header for 4.1 (aka 4.5)?

This patch now applies to version 3.0, 4.0 and 4.1 (aka 4.5). All these versions support #pragma omp task.

Looks good to me.

This revision (1) implements the OMPT support for the task switch event, and (2) brings the interface for the event in line with the current OMPT specification.

jlpeyton added inline comments.Nov 11 2015, 9:35 AM
runtime/src/include/41/ompt.h.var
316–319 ↗(On Diff #39929)

Should this be changed in 40/ompt.h.var and 30/ompt.h.var as well?

Complete update for OpenMP 3.0, 4.0 and 4.1 (aka 4.5).

This revision was automatically updated to reflect the committed changes.