This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][NFC] Added a note about the P2520R0
ClosedPublic

Authored by phyBrackets on Mar 1 2023, 10:44 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG9266edfcfd9e: [libcxx][NFC] Added a note about the P2520R0

Diff Detail

Event Timeline

phyBrackets created this revision.Mar 1 2023, 10:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 10:44 AM
phyBrackets requested review of this revision.Mar 1 2023, 10:44 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2023, 10:44 AM
Mordante requested changes to this revision.Mar 1 2023, 10:59 AM
Mordante added a subscriber: Mordante.

Thanks for the patch!

libcxx/docs/Status/Cxx2b.rst
45

This change needs a second change in libcxx/docs/Status/Cxx2bPapers.csv; just look what's done for P1413.

edit I see the CI failed, I assume this missing part is the cause.

This revision now requires changes to proceed.Mar 1 2023, 10:59 AM
phyBrackets marked an inline comment as done.

Thanks @Mordante , updated!

Mordante accepted this revision.Mar 1 2023, 12:39 PM

LGTM, I see the CI was broken by your previous commit (Louis fixed it) but the documentation is green. So feel free to commit.

This revision is now accepted and ready to land.Mar 1 2023, 12:39 PM
This revision was landed with ongoing or failed builds.Mar 1 2023, 6:28 PM
This revision was automatically updated to reflect the committed changes.