This is an archive of the discontinued LLVM Phabricator instance.

Differential D144991

[libc] fix strtofloat test with 128 bit floats
ClosedPublic

Authored by michaelrj on Feb 28 2023, 10:58 AM.

Details

Reviewers
None
Commits
rG2dd527b6f820: [libc] fix strtofloat test with 128 bit floats

Diff Detail

Event Timeline

michaelrj created this revision.Feb 28 2023, 10:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 28 2023, 10:58 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Feb 28 2023, 10:58 AM
Harbormaster completed remote builds in B216536: Diff 501230.Feb 28 2023, 10:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2023, 10:59 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG2dd527b6f820: [libc] fix strtofloat test with 128 bit floats (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG2dd527b6f820: [libc] fix strtofloat test with 128 bit floats.

Revision Contents

PathSize
libc/
test/
src/
__support/
2 lines

Diff 501231

libc/test/src/__support/str_to_float_test.cpp

Show First 20 Lines • Show All 343 Lines • ▼ Show 20 Lines eisel_lemire_test<long double>(
(UInt128(0x1234567812345678) << 64) + UInt128(0x1234567812345678), -300, (UInt128(0x1234567812345678) << 64) + UInt128(0x1234567812345678), -300,
(UInt128(0x1861fd734ec30) << 64) + UInt128(0x8afa7189f0f7595f), 15510); (UInt128(0x1861fd734ec30) << 64) + UInt128(0x8afa7189f0f7595f), 15510);
} }
TEST_F(LlvmLibcStrToFloatTest, EiselLemireFloat128Fallback) { TEST_F(LlvmLibcStrToFloatTest, EiselLemireFloat128Fallback) {
ASSERT_FALSE( ASSERT_FALSE(
__llvm_libc::internal::eisel_lemire<long double>( __llvm_libc::internal::eisel_lemire<long double>(
{(UInt128(0x5ce0e9a56015fec5) << 64) + UInt128(0xaadfa328ae39b333), {(UInt128(0x5ce0e9a56015fec5) << 64) + UInt128(0xaadfa328ae39b333),
1}, ) 1})
.has_value()); .has_value());
} }
#endif #endif