This is an archive of the discontinued LLVM Phabricator instance.

Avoid unintended integer overflow in bitstream handling
ClosedPublic

Authored by andrew.w.kaylor on Feb 23 2023, 11:28 AM.

Details

Summary

This change fixes two cases detected by static analysis where an operation is being performed on a 32-bit integer which may overflow and the result is assigned to a 64-bit integer.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 11:28 AM
andrew.w.kaylor requested review of this revision.Feb 23 2023, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 11:28 AM
tahonermann accepted this revision.Apr 14 2023, 1:13 PM

Sorry for the very delayed review, @andrew.w.kaylor; I managed not to see this request until now.

The changes look fine to me.

This revision is now accepted and ready to land.Apr 14 2023, 1:13 PM
This revision was landed with ongoing or failed builds.Aug 15 2023, 11:16 AM
This revision was automatically updated to reflect the committed changes.