[test] Remove occurences of br undef in Transform/Util tests

[kritgpt]

Summary

This patch removes br undef as suggested by https://discourse.llvm.org/t/please-dont-use-br-undef-in-tests-aka-please-avoid-test-cases-with-ub/63115

llvm/test/Transforms/Util/PredicateInfo/ordering.ll

 ; REQUIRES: asserts
 ; RUN: opt -passes=print-predicateinfo -debug < %s 2>&1 | FileCheck %s
 
 declare void @use(i32)
 declare void @use.i1(i1)
 
 ; Make sure we are visiting the values to build predicate infos for in a
 ; deterministic order.
-define i32 @test12(i32 %x, i32 %y) {
+define i32 @test12(i32 %x, i32 %y, i1 %c1) {
 ; CHECK: Visiting   %lcmp = icmp eq i32 %x, 0
 ; CHECK: Visiting i32 %x
 ; CHECK: Visiting   %lcmp2 = icmp slt i32 %y, 1000
 ; CHECK: Visiting i32 %y
 ; CHECK: Visiting   %lcmp3 = icmp slt i32 %y.0, 900
 ; CHECK: Visiting   %lcmp4 = icmp slt i32 %y.0.1, 700
 ; CHECK: Visiting   %lcmp5 = icmp slt i32 %y.0.1.2, 700
 ; CHECK: Visiting   %lcmp6 = icmp slt i32 %y.0.1.2.3, 700
 ; CHECK: Visiting   %lcmp7 = icmp slt i32 %y.0.1.2.3.4, 700
 ; CHECK: Visiting   %rcmp = icmp eq i32 %x, 0
 entry:
-  br i1 undef, label %left, label %right
+  br i1 %c1, label %left, label %right
 
 left:
   %lcmp = icmp eq i32 %x, 0
   br i1 %lcmp, label %left_cond_true, label %left_cond_false
 
 left_cond_true:
   %lcmp2 = icmp slt i32 %y, 1000
   br i1 %lcmp2, label %left_cond_true2, label %left_ret

llvm/test/Transforms/Util/lowerswitch.ll

; CHECK-NEXT: %tmp2 = phi i32 [ 2, %NodeBlock ], [ 5, %bb2 ], [ 2, %LeafBlock3 ]
   %tmp2 = phi i32 [ 2, %bb1 ], [ 2, %bb1 ], [ 5, %bb2 ], [ 2, %bb1 ]
   br label %exit
 
 exit:
   ret void
 }
 
 ; Test that we don't crash.
-define void @test2(i32 %mode) {
+define void @test2(i32 %mode, i1 %c1, i1 %c2, i1 %c3, i1 %c4, i1 %c5, i1 %c6) {
 ; CHECK-LABEL: @test2
-  br i1 undef, label %1, label %._crit_edge
+  br i1 %c1, label %1, label %._crit_edge
 
 ; <label>:1                                       ; preds = %0
   switch i32 %mode, label %33 [
     i32 2, label %2
     i32 3, label %3
     i32 4, label %4
     i32 5, label %5
     i32 6, label %6

 
 ; <label>:8                                       ; preds = %1
   br label %34
 
 ; <label>:9                                       ; preds = %1
   br label %34
 
 ; <label>:10                                      ; preds = %1
-  br i1 undef, label %11, label %12
+  br i1 %c2, label %11, label %12
 
 ; <label>:11                                      ; preds = %10
   br label %13
 
 ; <label>:12                                      ; preds = %10
   br label %13
 
 ; <label>:13                                      ; preds = %12, %11
   br label %34
 
 ; <label>:14                                      ; preds = %1
-  br i1 undef, label %15, label %16
+  br i1 %c3, label %15, label %16
 
 ; <label>:15                                      ; preds = %14
   br label %17
 
 ; <label>:16                                      ; preds = %14
   br label %17
 
 ; <label>:17                                      ; preds = %16, %15
   br label %34
 
 ; <label>:18                                      ; preds = %1
-  br i1 undef, label %19, label %20
+  br i1 %c4, label %19, label %20
 
 ; <label>:19                                      ; preds = %18
   br label %21
 
 ; <label>:20                                      ; preds = %18
   br label %21
 
 ; <label>:21                                      ; preds = %20, %19
   br label %34
 
 ; <label>:22                                      ; preds = %1
-  br i1 undef, label %23, label %24
+  br i1 %c5, label %23, label %24
 
 ; <label>:23                                      ; preds = %22
   br label %25
 
 ; <label>:24                                      ; preds = %22
   br label %25
 
 ; <label>:25                                      ; preds = %24, %23
   br label %34
 
 ; <label>:26                                      ; preds = %1
   br label %34
 
 ; <label>:27                                      ; preds = %1
-  br i1 undef, label %28, label %29
+  br i1 %c6, label %28, label %29
 
 ; <label>:28                                      ; preds = %27
   br label %30
 
 ; <label>:29                                      ; preds = %27
   br label %30
 
 ; <label>:30                                      ; preds = %29, %28

 
 ._crit_edge:                                      ; preds = %34, %0
   ret void
 }
 
 ; Test that the PHI node in for.cond should have one entry for each predecessor
 ; of its parent basic block after lowerswitch merged several cases into a new
 ; default block.
-define void @test3(i32 %mode) {
+define void @test3(i32 %mode, i1 %c1, i1 %c2) {
 ; CHECK-LABEL: @test3
 entry:
   br label %lbl1
 
 lbl1:                                             ; preds = %cleanup, %entry
   br label %lbl2
 
 lbl2:                                             ; preds = %cleanup, %lbl1
   br label %for.cond
 
 for.cond:                                         ; preds = %cleanup, %cleanup, %lbl2
 ; CHECK: for.cond:
 ; CHECK: phi i16 [ undef, %lbl2 ], [ %b.3, %LeafBlock ], [ %b.3, %LeafBlock1 ]{{$}}
 ; CHECK: for.cond1:
   %b.2 = phi i16 [ undef, %lbl2 ], [ %b.3, %cleanup ], [ %b.3, %cleanup ]
   br label %for.cond1
 
 for.cond1:                                        ; preds = %for.inc, %for.cond
   %b.3 = phi i16 [ %b.2, %for.cond ], [ undef, %for.inc ]
   %tobool = icmp ne i16 %b.3, 0
   br i1 %tobool, label %for.body, label %for.end
 
 for.body:                                         ; preds = %for.cond1
-  br i1 undef, label %if.then, label %for.inc
+  br i1 %c1, label %if.then, label %for.inc
 
 if.then:                                          ; preds = %for.body
   br label %cleanup
 
 for.inc:                                          ; preds = %for.body
   br label %for.cond1
 
 for.end:                                          ; preds = %for.cond1
-  br i1 undef, label %if.then4, label %for.body7
+  br i1 %c2, label %if.then4, label %for.body7
 
 if.then4:                                         ; preds = %for.end
   br label %cleanup
 
 for.body7:                                        ; preds = %for.end
   br label %cleanup
 
 cleanup:                                          ; preds = %for.body7, %if.then4, %if.then
; CHECK: return:
   unreachable
 
 return:
   ret void
 }
 
 ; Test that the PHI node in for.inc is updated correctly as the switch is
 ; replaced with a single branch to for.inc
-define void @test5(i32 %mode) {
+define void @test5(i32 %mode, i1 %c1) {
 ; CHECK-LABEL: @test5
 entry:
-  br i1 undef, label %cleanup10, label %cleanup10.thread
+  br i1 %c1, label %cleanup10, label %cleanup10.thread
 
 cleanup10.thread:
   br label %for.inc
 
 cleanup10:
   switch i32 %mode, label %unreachable [
     i32 0, label %for.inc
     i32 4, label %for.inc

llvm/test/Transforms/Util/simplify-dbg-declare-load.ll

 ; RUN: opt -passes=instcombine -instcombine-lower-dbg-declare=1 -S < %s | FileCheck %s
 ; RUN: opt -passes=instcombine -instcombine-lower-dbg-declare=0 -S < %s | FileCheck %s --check-prefix=DECLARE
 ; XFAIL: *
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-pc-linux-gnu"
 
 %foo = type { i64, i32, i32 }
 
 ; Function Attrs: nounwind readnone
 declare void @llvm.dbg.declare(metadata, metadata, metadata) #0
 declare void @llvm.dbg.value(metadata, metadata, metadata) #0
 
 ; Function Attrs: sspreq
-define void @julia_fastshortest_6256() #1 {
+define void @julia_fastshortest_6256(i1 %c1) #1 {
 top:
   %cp = alloca %foo, align 8
   %sink = alloca %foo, align 8
   call void @llvm.dbg.declare(metadata ptr %cp, metadata !1, metadata !16), !dbg !17
-  br i1 undef, label %idxend, label %fail
+  br i1 %c1, label %idxend, label %fail
 
 fail:                                             ; preds = %top
   unreachable
 
 idxend:                                           ; preds = %top
 ; CHECK-NOT: call void @llvm.dbg.value(metadata ptr %cp,
   %0 = load %foo, ptr %cp, align 8
   store volatile %foo %0, ptr %sink, align 8