Page MenuHomePhabricator
Differential D143432

[libc++] Addresses LWG3103.
ClosedPublic
Actions

Authored by Mordante on Feb 6 2023, 12:46 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG20b538fc641e: [libc++] Addresses LWG3103.
Summary
LWG3103 Errors in taking subview of span should be ill-formed where possible

Note that the real work was already done before, including tests.

Diff Detail

Event Timeline

Mordante created this revision.Feb 6 2023, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 12:46 PM
Mordante requested review of this revision.Feb 6 2023, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 12:46 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B212191: Diff 495254.Feb 6 2023, 1:52 PM
Mordante updated this revision to Diff 495427.Feb 7 2023, 1:38 AM

CI fixes.

Mordante updated this revision to Diff 495429.Feb 7 2023, 1:43 AM

Rebased to fix CI.

Harbormaster completed remote builds in B212315: Diff 495429.Feb 7 2023, 3:09 AM
ldionne accepted this revision.Fri, Mar 3, 1:26 PM
This revision is now accepted and ready to land.Fri, Mar 3, 1:26 PM
This revision was landed with ongoing or failed builds.Sat, Mar 4, 4:24 AM
Closed by commit rG20b538fc641e: [libc++] Addresses LWG3103. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG20b538fc641e: [libc++] Addresses LWG3103..

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
2 lines
test/
std/
containers/
views/
views.span/
span.sub/
3 lines
2 lines
3 lines
2 lines
3 lines
3 lines

Diff 502369

View Options

libcxx/docs/Status/Cxx20Issues.csv

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/first.pass.cpp

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/first.verify.cpp

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/last.pass.cpp

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/last.verify.cpp

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/subspan.pass.cpp

Loading...
View Options

libcxx/test/std/containers/views/views.span/span.sub/subspan.verify.cpp

Loading...