This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix pthread argument for scudo integration tests when using GCC
ClosedPublic

Authored by DavidSpickett on Feb 3 2023, 3:09 AM.

Details

Summary

This adds "-pthreads" which appears to be a clang only
alias for "-pthread" (all the drivers check for both).

Use "-pthread" instead to be compatible with gcc.

Otherwise you get:
FAILED: bin/libc-gwp-asan-uaf-should-crash
: && /usr/bin/g++-11 <...> -pthreads <...> projects/libc/test/integration/scudo/liblibc_for_scudo_integration_test.a && :
g++-11: error: unrecognized command-line option ‘-pthreads’; did you mean ‘-pthread’?

Diff Detail

Event Timeline

DavidSpickett created this revision.Feb 3 2023, 3:09 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 3 2023, 3:09 AM
DavidSpickett requested review of this revision.Feb 3 2023, 3:09 AM
This revision is now accepted and ready to land.Feb 3 2023, 3:18 PM