This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory
ClosedPublic

Authored by JDevlieghere on Jan 31 2023, 3:26 PM.

Details

Summary

We no longer need to remove a directory downstream and also contrary to my previous observations, remove_directory isn't sufficient to remove a regular file.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 31 2023, 3:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 3:26 PM
JDevlieghere requested review of this revision.Jan 31 2023, 3:26 PM
bulbazord accepted this revision.Jan 31 2023, 3:27 PM
This revision is now accepted and ready to land.Jan 31 2023, 3:27 PM
This revision was landed with ongoing or failed builds.Jan 31 2023, 3:34 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 3:34 PM