This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Addresses LWG3782.
ClosedPublic

Authored by Mordante on Jan 28 2023, 10:56 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG853059a15011: [libc++] Addresses LWG3782.
Summary
  1. Should <math.h> declare ::lerp?

Libc++ doesn't declare ::lerp, adds tests to validate the requirement.

Diff Detail

Event Timeline

Mordante created this revision.Jan 28 2023, 10:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 10:56 AM
Mordante requested review of this revision.Jan 28 2023, 10:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 10:56 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Feb 21 2023, 5:19 PM
philnik added a subscriber: philnik.

LGTM % comment.

libcxx/test/std/language.support/support.c.headers/support.c.headers.other/math.lerp.verify.cpp
27 ↗(On Diff #493023)

<math.h> is still allowed to include <cmath> (I think libstdc++ might do that), so this should be inside test/libcxx if we want to test it at all. Removing this should also fix the modules build.

This revision is now accepted and ready to land.Feb 21 2023, 5:19 PM
Mordante marked an inline comment as done.Feb 28 2023, 9:31 AM

Thanks for the review!

This revision was landed with ongoing or failed builds.Feb 28 2023, 9:31 AM
This revision was automatically updated to reflect the committed changes.