This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN] Copy some ASAN independent unit tests from ASAN to LSAN
ClosedPublic

Authored by kstoimenov on Jan 24 2023, 1:25 PM.

Diff Detail

Event Timeline

kstoimenov created this revision.Jan 24 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:25 PM
Herald added a subscriber: Enna1. · View Herald Transcript
kstoimenov requested review of this revision.Jan 24 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 1:25 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Removed fixme.

vitalybuka added inline comments.Jan 24 2023, 1:47 PM
compiler-rt/lib/hwasan/hwasan.cpp
90 ↗(On Diff #491895)

check-lsan should also run with hwasan
are you going to do that in a separate patch?

if these are the only tests in asan, try to move them into lsan first

compiler-rt/test/hwasan/TestCases/Linux/leak_check_segv.cpp
9 ↗(On Diff #491895)

this one does not look asan/hwasan specific,
it's should be moved from asan->lsan

compiler-rt/test/hwasan/TestCases/Linux/signal_during_stop_the_world.cpp
28 ↗(On Diff #491895)

this one does not look asan/hwasan specific,
it's should be moved from asan->lsan

compiler-rt/test/hwasan/TestCases/lsan_annotations.cpp
10 ↗(On Diff #491895)

this one as well

compiler-rt/test/hwasan/TestCases/lsan_crash.cpp
15 ↗(On Diff #491895)

and this one

Moved tests to LSAN.

Removed hwasan.

Removed hwasan.

kstoimenov retitled this revision from [HWASAN] Turn on LSAN in HWASAN and copy ASAN unit tests to [HWASAN] Copy some LSAN specific unit tests from LSAN to ASAN..Jan 24 2023, 3:56 PM
vitalybuka accepted this revision.Jan 24 2023, 3:56 PM
vitalybuka added inline comments.
compiler-rt/test/lsan/TestCases/Linux/leak_check_segv.cpp
2

I guess leak-detection is redundant here

This revision is now accepted and ready to land.Jan 24 2023, 3:56 PM
kstoimenov retitled this revision from [HWASAN] Copy some LSAN specific unit tests from LSAN to ASAN. to [HWASAN] Copy some ASAN independent unit tests from ASAN to LSAN.Jan 24 2023, 3:56 PM

Removed REQUIRES: leak-detection

This revision was landed with ongoing or failed builds.Jan 24 2023, 4:40 PM
This revision was automatically updated to reflect the committed changes.