This is an archive of the discontinued LLVM Phabricator instance.

Fix warning in JITLink/EHFrameSupportTests.cpp
Needs ReviewPublic

Authored by philipp.tomsich on Jan 23 2023, 3:53 PM.

This revision needs review, but there are no reviewers specified.

Summary

Fixes "warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]".

Path

Size

llvm/

unittests/

ExecutionEngine/

JITLink/

3 lines

Show First 20 Lines • Show All 179 Lines • ▼ Show 20 Lines	TEST(EHFrameCFIBlockInspector, BasicSuccessCase) {
assert(EHFrame && "eh-frame missing?");		assert(EHFrame && "eh-frame missing?");

SmallVector<Block *, 2> CIEs;		SmallVector<Block *, 2> CIEs;
for (auto *B : EHFrame->blocks()) {		for (auto *B : EHFrame->blocks()) {
auto CFIBI = EHFrameCFIBlockInspector::FromEdgeScan(*B);		auto CFIBI = EHFrameCFIBlockInspector::FromEdgeScan(*B);
if (CFIBI.isCIE()) {		if (CFIBI.isCIE()) {
CIEs.push_back(B);		CIEs.push_back(B);
// If this CIE has an edge, check that getPersonalityEdge returns it.		// If this CIE has an edge, check that getPersonalityEdge returns it.
if (B->edges_size() != 0)		if (B->edges_size() != 0) {
EXPECT_TRUE(!!CFIBI.getPersonalityEdge());		EXPECT_TRUE(!!CFIBI.getPersonalityEdge());
}		}
}		}
		}
ASSERT_EQ(CIEs.size(), 2U);		ASSERT_EQ(CIEs.size(), 2U);

// Make sure that the CIE with no edges is CIEs[0].		// Make sure that the CIE with no edges is CIEs[0].
if (CIEs[1]->edges_empty())		if (CIEs[1]->edges_empty())
std::swap(CIEs[0], CIEs[1]);		std::swap(CIEs[0], CIEs[1]);

EXPECT_TRUE(CIEs[0]->edges_empty());		EXPECT_TRUE(CIEs[0]->edges_empty());
EXPECT_EQ(CIEs[1]->edges_size(), 1U);		EXPECT_EQ(CIEs[1]->edges_size(), 1U);
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines