This is an archive of the discontinued LLVM Phabricator instance.

Differential D142367

Add support for clang-cl's option -fexcess-precision.
ClosedPublic

Authored by zahiraam on Jan 23 2023, 7:45 AM.

Details

Reviewers
mdtoguchi
andrew.w.kaylor
Commits
rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`.
Summary

This option is useful for clang and clang-cl.

Diff Detail

Event Timeline

zahiraam created this revision.Jan 23 2023, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 7:45 AM
zahiraam requested review of this revision.Jan 23 2023, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 7:45 AM
mdtoguchi accepted this revision.Jan 23 2023, 8:36 AM
This revision is now accepted and ready to land.Jan 23 2023, 8:36 AM
This revision was landed with ongoing or failed builds.Jan 23 2023, 9:08 AM
Closed by commit rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). · Explain Why
This revision was automatically updated to reflect the committed changes.
zahiraam added a commit: rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`..
zahiraam added a subscriber: thakis.Jan 23 2023, 9:09 AM

@thakis I think this should fix the clang-cl use with the Mac OS compiler.

Harbormaster completed remote builds in B209377: Diff 491374.Jan 23 2023, 9:23 AM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
1 line
test/
Driver/
36 lines

Diff 491413

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,573 Lines • ▼ Show 20 Linesdef exception_model : Separate<["-"], "exception-model">,
NormalizedValues<["DwarfCFI", "SjLj", "WinEH", "Wasm"]>, NormalizedValues<["DwarfCFI", "SjLj", "WinEH", "Wasm"]>,
MarshallingInfoEnum<LangOpts<"ExceptionHandling">, "None">; MarshallingInfoEnum<LangOpts<"ExceptionHandling">, "None">;
def exception_model_EQ : Joined<["-"], "exception-model=">, def exception_model_EQ : Joined<["-"], "exception-model=">,
Flags<[CC1Option, NoDriverOption]>, Alias<exception_model>; Flags<[CC1Option, NoDriverOption]>, Alias<exception_model>;
def fignore_exceptions : Flag<["-"], "fignore-exceptions">, Group<f_Group>, Flags<[CC1Option]>, def fignore_exceptions : Flag<["-"], "fignore-exceptions">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Enable support for ignoring exception handling constructs">, HelpText<"Enable support for ignoring exception handling constructs">,
MarshallingInfoFlag<LangOpts<"IgnoreExceptions">>; MarshallingInfoFlag<LangOpts<"IgnoreExceptions">>;
def fexcess_precision_EQ : Joined<["-"], "fexcess-precision=">, Group<f_Group>, def fexcess_precision_EQ : Joined<["-"], "fexcess-precision=">, Group<f_Group>,
Flags<[CoreOption]>,
HelpText<"Allows control over excess precision on targets where native " HelpText<"Allows control over excess precision on targets where native "
"support for the precision types is not available. By default, excess " "support for the precision types is not available. By default, excess "
"precision is used to calculate intermediate results following the " "precision is used to calculate intermediate results following the "
"rules specified in ISO C99.">, "rules specified in ISO C99.">,
Values<"standard,fast,none">, NormalizedValuesScope<"LangOptions">, Values<"standard,fast,none">, NormalizedValuesScope<"LangOptions">,
NormalizedValues<["FPP_Standard", "FPP_Fast", "FPP_None"]>; NormalizedValues<["FPP_Standard", "FPP_Fast", "FPP_None"]>;
def ffloat16_excess_precision_EQ : Joined<["-"], "ffloat16-excess-precision=">, def ffloat16_excess_precision_EQ : Joined<["-"], "ffloat16-excess-precision=">,
Group<f_Group>, Flags<[CC1Option, NoDriverOption]>, Group<f_Group>, Flags<[CC1Option, NoDriverOption]>,
▲ Show 20 Lines • Show All 5,522 Lines • Show Last 20 Lines

clang/test/Driver/fexcess-precision.c

// Note: %s must be preceded by --, otherwise it may be interpreted as a
// command-line option, e.g. on Mac where %s is commonly under /Users.
// RUN: %clang -### -target i386 -fexcess-precision=fast -c %s 2>&1 \ // RUN: %clang -### -target i386 -fexcess-precision=fast -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FAST %s
// RUN: %clang_cl -### -target i386 -fexcess-precision=fast -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FAST %s
// RUN: %clang -### -target i386 -fexcess-precision=standard -c %s 2>&1 \ // RUN: %clang -### -target i386 -fexcess-precision=standard -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-STD %s // RUN: | FileCheck --check-prefix=CHECK-STD %s
// RUN: %clang_cl -### -target i386 -fexcess-precision=standard -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-STD %s
// RUN: %clang -### -target i386 -fexcess-precision=16 -c %s 2>&1 \ // RUN: %clang -### -target i386 -fexcess-precision=16 -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NONE %s // RUN: | FileCheck --check-prefix=CHECK-NONE %s
// RUN: %clang_cl -### -target i386 -fexcess-precision=16 -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NONE %s
// RUN: %clang -### -target i386 -fexcess-precision=none -c %s 2>&1 \ // RUN: %clang -### -target i386 -fexcess-precision=none -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s // RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s
// RUN: %clang_cl -### -target i386 -fexcess-precision=none -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s
// RUN: %clang -### -target x86_64 -fexcess-precision=fast -c %s 2>&1 \ // RUN: %clang -### -target x86_64 -fexcess-precision=fast -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FAST %s
// RUN: %clang_cl -### -target x86_64 -fexcess-precision=fast -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FAST %s
// RUN: %clang -### -target x86_64 -fexcess-precision=standard -c %s 2>&1 \ // RUN: %clang -### -target x86_64 -fexcess-precision=standard -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-STD %s // RUN: | FileCheck --check-prefix=CHECK-STD %s
// RUN: %clang_cl -### -target x86_64 -fexcess-precision=standard -c \
// RUN: -- %s 2>&1 | FileCheck --check-prefix=CHECK-STD %s
// RUN: %clang -### -target x86_64 -fexcess-precision=16 -c %s 2>&1 \ // RUN: %clang -### -target x86_64 -fexcess-precision=16 -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NONE %s // RUN: | FileCheck --check-prefix=CHECK-NONE %s
// RUN: %clang_cl -### -target x86_64 -fexcess-precision=16 -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NONE %s
// RUN: %clang -### -target x86_64 -fexcess-precision=none -c %s 2>&1 \ // RUN: %clang -### -target x86_64 -fexcess-precision=none -c %s 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK-ERR-NONE %s // RUN: | FileCheck --check-prefixes=CHECK-ERR-NONE %s
// RUN: %clang_cl -### -target x86_64 -fexcess-precision=none -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefixes=CHECK-ERR-NONE %s
// RUN: %clang -### -target aarch64 -fexcess-precision=fast -c %s 2>&1 \ // RUN: %clang -### -target aarch64 -fexcess-precision=fast -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK %s // RUN: | FileCheck --check-prefix=CHECK %s
// RUN: %clang_cl -### -target aarch64 -fexcess-precision=fast -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK %s
// RUN: %clang -### -target aarch64 -fexcess-precision=standard -c %s 2>&1 \ // RUN: %clang -### -target aarch64 -fexcess-precision=standard -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK %s // RUN: | FileCheck --check-prefix=CHECK %s
// RUN: %clang_cl -### -target aarch64 -fexcess-precision=standard -c \
// RUN: -- %s 2>&1 | FileCheck --check-prefix=CHECK %s
// RUN: %clang -### -target aarch64 -fexcess-precision=16 -c %s 2>&1 \ // RUN: %clang -### -target aarch64 -fexcess-precision=16 -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-16 %s // RUN: | FileCheck --check-prefix=CHECK-ERR-16 %s
// RUN: %clang_cl -### -target aarch64 -fexcess-precision=16 -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-16 %s
// RUN: %clang -### -target aarch64 -fexcess-precision=none -c %s 2>&1 \ // RUN: %clang -### -target aarch64 -fexcess-precision=none -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s // RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s
// RUN: %clang_cl -### -target aarch64 -fexcess-precision=none -c -- %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-ERR-NONE %s
// CHECK-FAST: "-ffloat16-excess-precision=fast" // CHECK-FAST: "-ffloat16-excess-precision=fast"
// CHECK-STD: "-ffloat16-excess-precision=standard" // CHECK-STD: "-ffloat16-excess-precision=standard"
// CHECK-NONE: "-ffloat16-excess-precision=none" // CHECK-NONE: "-ffloat16-excess-precision=none"
// CHECK-ERR-NONE: unsupported argument 'none' to option '-fexcess-precision=' // CHECK-ERR-NONE: unsupported argument 'none' to option '-fexcess-precision='
// CHECK: "-cc1" // CHECK: "-cc1"
// CHECK-NOT: "-ffloat16-excess-precision=fast" // CHECK-NOT: "-ffloat16-excess-precision=fast"
// CHECK-ERR-16: unsupported argument '16' to option '-fexcess-precision=' // CHECK-ERR-16: unsupported argument '16' to option '-fexcess-precision='