This is an archive of the discontinued LLVM Phabricator instance.

Differential D142225

[memprof] Change test output redirection to enable it to run on Windows
ClosedPublic

Authored by andrewng on Jan 20 2023, 8:30 AM.

Details

Reviewers
snehasish
Commits
rG3133030446cb: [memprof] Change test output redirection to enable it to run on Windows

Diff Detail

Event Timeline

andrewng created this revision.Jan 20 2023, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 8:30 AM
andrewng requested review of this revision.Jan 20 2023, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 8:30 AM
Harbormaster completed remote builds in B209004: Diff 490872.Jan 20 2023, 10:28 AM
snehasish accepted this revision.Jan 26 2023, 1:19 PM

While the change itself looks good to me, this test is for linux (REQUIRES: x86_64-linux). Is there some motivation for this change?

This revision is now accepted and ready to land.Jan 26 2023, 1:19 PM
andrewng added a comment.Jan 27 2023, 1:55 AM

While the change itself looks good to me, this test is for linux (REQUIRES: x86_64-linux). Is there some motivation for this change?

If you build a Windows LLVM toolchain that targets x86_64-linux by default (i.e. cross compilation for Linux on Windows), then this test will be run.

Thanks for the review.

This revision was landed with ongoing or failed builds.Jan 30 2023, 2:43 AM
Closed by commit rG3133030446cb: [memprof] Change test output redirection to enable it to run on Windows (authored by andrewng). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrewng added a commit: rG3133030446cb: [memprof] Change test output redirection to enable it to run on Windows.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-profdata/
2 lines

Diff 493257

llvm/test/tools/llvm-profdata/memprof-pic.test

Show All 30 Lines
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \ clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-fno-optimize-sibling-calls -m64 -Wl,-build-id -pie \ -fno-optimize-sibling-calls -m64 -Wl,-build-id -pie \
source.c -o pic.memprofexe source.c -o pic.memprofexe
env MEMPROF_OPTIONS=log_path=stdout ./pic.memprofexe > pic.memprofraw env MEMPROF_OPTIONS=log_path=stdout ./pic.memprofexe > pic.memprofraw
``` ```
RUN: not llvm-profdata show --memory %p/Inputs/pic.memprofraw --profiled-binary %p/Inputs/pic.memprofexe -o - |& FileCheck %s RUN: not llvm-profdata show --memory %p/Inputs/pic.memprofraw --profiled-binary %p/Inputs/pic.memprofexe -o - 2>&1 | FileCheck %s
CHECK: Unsupported position independent code CHECK: Unsupported position independent code