This is an archive of the discontinued LLVM Phabricator instance.

[lldb-vscode] Fix an issue where lldb-vscode tries to display a source file for generated code
Needs ReviewPublic

Authored by ivanhernandez13 on Jan 12 2023, 2:36 PM.

Details

Reviewers
clayborg
Summary

According to
https://github.com/llvm/llvm-project/blob/fbcefff9d0a3f5e97270ef8e7b8e0f2afc33dc1c/lldb/source/Symbol/LineEntry.cpp#L215,
a line entry of 0 indicates compiler generated code. Despite it
being generated code, the SBLineEntry.GetFileSpec().IsValid() check
can be true in which case lldb-vscode responds with a non-existent
file named "<compiler-generated>". This patch will instead have
lldb-vscode return the disassembly of the generated code.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 2:36 PM
ivanhernandez13 requested review of this revision.Jan 12 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 2:36 PM

Change looks good. It would be nice to test this if possible.