This is an archive of the discontinued LLVM Phabricator instance.

Differential D141181

[libcxx] remove weird empty line
ClosedPublic

Authored by Backl1ght on Jan 6 2023, 10:10 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG1920c7947ab4: [libc++] remove weird empty line
Summary

I think empty line here is weird.

Diff Detail

Event Timeline

Backl1ght created this revision.Jan 6 2023, 10:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 10:10 PM
Backl1ght requested review of this revision.Jan 6 2023, 10:10 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2023, 10:10 PM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B206245: Diff 487047.Jan 6 2023, 11:26 PM
philnik accepted this revision.Jan 7 2023, 1:08 AM

LGTM FWIW.

This revision is now accepted and ready to land.Jan 7 2023, 1:08 AM
Closed by commit rG1920c7947ab4: [libc++] remove weird empty line (authored by Backl1ght). · Explain WhyJan 7 2023, 2:22 AM
This revision was automatically updated to reflect the committed changes.
Backl1ght added a commit: rG1920c7947ab4: [libc++] remove weird empty line.

Revision Contents

PathSize
libcxx/
include/
__algorithm/
1 line

Diff 487071

libcxx/include/__algorithm/partial_sort.h

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines_RandomAccessIterator __partial_sort_impl(
_RandomAccessIterator __i = __middle; _RandomAccessIterator __i = __middle;
for (; __i != __last; ++__i) for (; __i != __last; ++__i)
{ {
if (__comp(*__i, *__first)) if (__comp(*__i, *__first))
{ {
_IterOps<_AlgPolicy>::iter_swap(__i, __first); _IterOps<_AlgPolicy>::iter_swap(__i, __first);
std::__sift_down<_AlgPolicy>(__first, __comp, __len, __first); std::__sift_down<_AlgPolicy>(__first, __comp, __len, __first);
} }
} }
std::__sort_heap<_AlgPolicy>(std::move(__first), std::move(__middle), __comp); std::__sort_heap<_AlgPolicy>(std::move(__first), std::move(__middle), __comp);
return __i; return __i;
} }
template <class _AlgPolicy, class _Compare, class _RandomAccessIterator, class _Sentinel> template <class _AlgPolicy, class _Compare, class _RandomAccessIterator, class _Sentinel>
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20
Show All 39 Lines