[libc++][test] Suppress MSVC warnings in std::expected tests

[CaseyCarter]

Summary

• initializing shorts with shorts instead of ints to avoid narrowing warnings
• Explicitly discard the result of value calls to avoid [[nodiscard]] warnings

Drive-by: testException from value test is duplicated in value_or test; remove the duplicate.

[huixie90]

Thank you for the fix

[huixie90]

Thank you for the tidy-up.

[CaseyCarter]

Merged as bdf7da280f624c53e6184d0410041220a9b405a7 (*sigh* someday I'll learn the right magic words to autoclose.)

libcxx/test/std/utilities/expected/expected.expected/ctor/ctor.inplace.pass.cpp

constexpr bool test() {
   {
     std::expected<int, int> e(std::in_place, 5);
     assert(e.has_value());
     assert(e.value() == 5);
   }
 
   // multi args
   {
-    std::expected<std::tuple<int, short, MoveOnly>, int> e(std::in_place, 1, 2, MoveOnly(3));
+    std::expected<std::tuple<int, short, MoveOnly>, int> e(std::in_place, 1, short{2}, MoveOnly(3));
     assert(e.has_value());
-    assert((e.value() == std::tuple<int, short, MoveOnly>(1, 2, MoveOnly(3))));
+    assert((e.value() == std::tuple<int, short, MoveOnly>(1, short{2}, MoveOnly(3))));
   }
 
   return true;
 }
 
 void testException() {
 #ifndef TEST_HAS_NO_EXCEPTIONS
   struct Except {};

libcxx/test/std/utilities/expected/expected.expected/ctor/ctor.unexpect.pass.cpp

constexpr bool test() {
   {
     std::expected<int, int> e(std::unexpect, 5);
     assert(!e.has_value());
     assert(e.error() == 5);
   }
 
   // multi args
   {
-    std::expected<int, std::tuple<int, short, MoveOnly>> e(std::unexpect, 1, 2, MoveOnly(3));
+    std::expected<int, std::tuple<int, short, MoveOnly>> e(std::unexpect, 1, short{2}, MoveOnly(3));
     assert(!e.has_value());
-    assert((e.error() == std::tuple<int, short, MoveOnly>(1, 2, MoveOnly(3))));
+    assert((e.error() == std::tuple<int, short, MoveOnly>(1, short{2}, MoveOnly(3))));
   }
 
   return true;
 }
 
 void testException() {
 #ifndef TEST_HAS_NO_EXCEPTIONS
   struct Except {};

libcxx/test/std/utilities/expected/expected.expected/observers/value.pass.cpp

 
 void testException() {
 #ifndef TEST_HAS_NO_EXCEPTIONS
 
   // int
   {
     const std::expected<int, int> e(std::unexpect, 5);
     try {
-      e.value();
+      (void) e.value();
       assert(false);
     } catch (const std::bad_expected_access<int>& ex) {
       assert(ex.error() == 5);
     }
   }
 
   // MoveOnly
   {
     std::expected<int, MoveOnly> e(std::unexpect, 5);
     try {
-      std::move(e).value();
+      (void) std::move(e).value();
       assert(false);
     } catch (const std::bad_expected_access<MoveOnly>& ex) {
       assert(ex.error() == 5);
     }
   }
 
 #endif // TEST_HAS_NO_EXCEPTIONS
 }
 
 int main(int, char**) {
   test();
   static_assert(test());
   testException();
   return 0;
 }

libcxx/test/std/utilities/expected/expected.expected/observers/value_or.pass.cpp

// &&, !has_value()
     std::expected<MoveOnly, int> e(std::unexpect, 5);
     std::same_as<MoveOnly> decltype(auto) x = std::move(e).value_or(10);
     assert(x == 10);
   }
 
   return true;
 }
 
-void testException() {
-#ifndef TEST_HAS_NO_EXCEPTIONS
-
-  // int
-  {
-    const std::expected<int, int> e(std::unexpect, 5);
-    try {
-      e.value();
-      assert(false);
-    } catch (const std::bad_expected_access<int>& ex) {
-      assert(ex.error() == 5);
-    }
-  }
-
-  // MoveOnly
-  {
-    std::expected<int, MoveOnly> e(std::unexpect, 5);
-    try {
-      std::move(e).value();
-      assert(false);
-    } catch (const std::bad_expected_access<MoveOnly>& ex) {
-      assert(ex.error() == 5);
-    }
-  }
-
-#endif // TEST_HAS_NO_EXCEPTIONS
-}
-
 int main(int, char**) {
   test();
   static_assert(test());
-  testException();
   return 0;
 }

libcxx/test/std/utilities/expected/expected.void/ctor/ctor.unexpect.pass.cpp

constexpr bool test() {
   {
     std::expected<void, int> e(std::unexpect, 5);
     assert(!e.has_value());
     assert(e.error() == 5);
   }
 
   // multi args
   {
-    std::expected<void, std::tuple<int, short, MoveOnly>> e(std::unexpect, 1, 2, MoveOnly(3));
+    std::expected<void, std::tuple<int, short, MoveOnly>> e(std::unexpect, 1, short{2}, MoveOnly(3));
     assert(!e.has_value());
-    assert((e.error() == std::tuple<int, short, MoveOnly>(1, 2, MoveOnly(3))));
+    assert((e.error() == std::tuple<int, short, MoveOnly>(1, short{2}, MoveOnly(3))));
   }
 
   return true;
 }
 
 void testException() {
 #ifndef TEST_HAS_NO_EXCEPTIONS
   struct Except {};