This is an archive of the discontinued LLVM Phabricator instance.

Revert an unintentional API ABI break
ClosedPublic

Authored by aprantl on Jan 5 2023, 1:37 PM.

Details

Summary

lldb::LanguageType is used as a parameter in SBExpressionOptions::SetLanguage(), which actually makes this type API too. Commit 6eaedbb52f2a616e644e5acc7279c8b07c4cfe82 added a : uint16_t to it, which broke binary compatibility for the SBAPI. This patch reverts to the original enum.

I tried moving the entire enum into include/API, but that created a cyclic module dependency between API and Utility. To keep things simple, this just reverts to the original code and adds a warning.

Diff Detail

Event Timeline

aprantl created this revision.Jan 5 2023, 1:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 1:37 PM
aprantl requested review of this revision.Jan 5 2023, 1:37 PM
JDevlieghere accepted this revision.Jan 5 2023, 1:38 PM

Ship it

This revision is now accepted and ready to land.Jan 5 2023, 1:38 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2023, 1:43 PM