This is an archive of the discontinued LLVM Phabricator instance.

Use a long-established error code instead of a newfangled one which causes portability problems
Needs ReviewPublic

Authored by he32 on Dec 27 2022, 2:38 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Use the long-established operation_not_supported instead of the rather newfangled state_not_recoverable error code.
The latter is not available on NetBSD 9.x, due to the host system not having ENOTRECOVERABLE
defined. NetBSD-current has it and the coming 10.0 will have it, though.

However, it can also be argued that operation_not_supported is a better fit for the actual error message,
which in essence says "Incremental mode for action %d is not supported".

Diff Detail

Event Timeline

he32 created this revision.Dec 27 2022, 2:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2022, 2:38 PM
Herald added a subscriber: krytarowski. · View Herald Transcript
he32 requested review of this revision.Dec 27 2022, 2:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2022, 2:38 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
he32 edited the summary of this revision. (Show Details)Dec 27 2022, 2:40 PM