This is an archive of the discontinued LLVM Phabricator instance.

Differential D140272

[libc++][CI] Fixes build failures.
ClosedPublic

Authored by Mordante on Dec 18 2022, 10:01 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGa538f7cfb1d7: [libc++][CI] Fixes build failures.
Summary

Some clang diagnostics have changed causing build failures.

Diff Detail

Unit TestsFailed

TimeTest
3,680 mslibcxx CI Clang-cl (DLL) > llvm-libc++-shared-clangcl-cfg-in.std/thread/thread_condition/thread_condition_condvar::notify_all.pass.cpp
11,890 mslibcxx CI Clang-cl (DLL) > llvm-libc++-shared-clangcl-cfg-in.std/thread/thread_mutex/thread_lock/thread_lock_unique/thread_lock_unique_cons::mutex_duration.pass.cpp
6,310 mslibcxx CI Clang-cl (Static) > llvm-libc++-static-clangcl-cfg-in.std/thread/futures/futures_async::async.pass.cpp

Event Timeline

Mordante created this revision.Dec 18 2022, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2022, 10:01 AM
Mordante requested review of this revision.Dec 18 2022, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2022, 10:01 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B203812: Diff 483825.Dec 18 2022, 11:18 AM
Mordante accepted this revision.Dec 18 2022, 11:18 AM
This revision is now accepted and ready to land.Dec 18 2022, 11:18 AM
This revision was landed with ongoing or failed builds.Dec 18 2022, 11:20 AM
Closed by commit rGa538f7cfb1d7: [libc++][CI] Fixes build failures. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGa538f7cfb1d7: [libc++][CI] Fixes build failures..
Mordante mentioned this in D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types.Dec 18 2022, 11:36 AM

Revision Contents

PathSize
libcxx/
test/
std/
localization/
locale.stdcvt/
6 lines
locales/
locale.convenience/
conversions/
conversions.buffer/
4 lines
conversions.string/
4 lines

Diff 483825

libcxx/test/std/localization/locale.stdcvt/depr.verify.cpp

Show All 10 Lines
// <codecvt> // <codecvt>
// ensure that codecvt content is marked as deprecated // ensure that codecvt content is marked as deprecated
#include <codecvt> #include <codecvt>
std::codecvt_mode c1; // expected-warning {{'codecvt_mode' is deprecated}} std::codecvt_mode c1; // expected-warning {{'codecvt_mode' is deprecated}}
std::codecvt_utf8<wchar_t> c2; // expected-warning {{'codecvt_utf8<wchar_t>' is deprecated}} std::codecvt_utf8<wchar_t> c2; // expected-warning-re {{'codecvt_utf8<wchar_t{{.*}}>' is deprecated}}
std::codecvt_utf16<wchar_t> c3; // expected-warning {{'codecvt_utf16<wchar_t>' is deprecated}} std::codecvt_utf16<wchar_t> c3; // expected-warning-re {{'codecvt_utf16<wchar_t{{.*}}>' is deprecated}}
std::codecvt_utf8_utf16<wchar_t> c4; // expected-warning {{'codecvt_utf8_utf16<wchar_t>' is deprecated}} std::codecvt_utf8_utf16<wchar_t> c4; // expected-warning-re {{'codecvt_utf8_utf16<wchar_t{{.*}}>' is deprecated}}

libcxx/test/std/localization/locales/locale.convenience/conversions/conversions.buffer/depr.verify.cpp

Show All 11 Lines
// <codecvt> // <codecvt>
// ensure that wbuffer_convert is marked as deprecated // ensure that wbuffer_convert is marked as deprecated
#include <codecvt> #include <codecvt>
#include <locale> #include <locale>
std::wbuffer_convert<std::codecvt_utf8<wchar_t>> c1; // expected-warning {{'wbuffer_convert<std::codecvt_utf8<wchar_t>>' is deprecated}} std::wbuffer_convert<std::codecvt_utf8<wchar_t>> c1; // expected-warning-re {{'wbuffer_convert<std::codecvt_utf8<wchar_t{{.*}}>>' is deprecated}}
// expected-warning@-1 {{'codecvt_utf8<wchar_t>' is deprecated}} // expected-warning-re@-1 {{'codecvt_utf8<wchar_t{{.*}}>' is deprecated}}

libcxx/test/std/localization/locales/locale.convenience/conversions/conversions.string/depr.verify.cpp

Show All 10 Lines
// <codecvt> // <codecvt>
// ensure that wstring_convert is marked as deprecated // ensure that wstring_convert is marked as deprecated
#include <codecvt> #include <codecvt>
#include <locale> #include <locale>
std::wstring_convert<std::codecvt_utf8<wchar_t>> c1; // expected-warning {{'wstring_convert<std::codecvt_utf8<wchar_t>>' is deprecated}} std::wstring_convert<std::codecvt_utf8<wchar_t>> c1; // expected-warning-re {{'wstring_convert<std::codecvt_utf8<wchar_t{{.*}}>>' is deprecated}}
// expected-warning@-1 {{'codecvt_utf8<wchar_t>' is deprecated}} // expected-warning-re@-1 {{'codecvt_utf8<wchar_t{{.*}}>' is deprecated}}