This is an archive of the discontinued LLVM Phabricator instance.

[LAA] Convert test to opaque pointers (NFC)
ClosedPublic

Authored by nikic on Dec 16 2022, 4:02 AM.

Details

Summary

When converting this test to opaque pointers (and dropping bitcast), we get improved memory checks. I wanted to confirm whether this is an expected change.

Diff Detail

Event Timeline

nikic created this revision.Dec 16 2022, 4:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 4:02 AM
nikic requested review of this revision.Dec 16 2022, 4:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2022, 4:02 AM
fhahn accepted this revision.Dec 19 2022, 4:13 AM

LGTM, thanks!

It looks like the difference is due to the logic that determines pointer strides in LAA not handling bitcasts. Without the bitcasts, the logic now triggers successfully.

This revision is now accepted and ready to land.Dec 19 2022, 4:13 AM
This revision was landed with ongoing or failed builds.Dec 19 2022, 7:58 AM
This revision was automatically updated to reflect the committed changes.