This is an archive of the discontinued LLVM Phabricator instance.

[include-cleaner] Include the reference type when printing the SymbolReference.
ClosedPublic

Authored by hokein on Dec 12 2022, 4:49 AM.

Details

Summary

This information is useful when printing the reference for debugging
purposes.

Diff Detail

Event Timeline

hokein created this revision.Dec 12 2022, 4:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 4:49 AM
hokein requested review of this revision.Dec 12 2022, 4:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 4:49 AM
kadircet accepted this revision.Dec 12 2022, 5:42 AM
kadircet added inline comments.
clang-tools-extra/include-cleaner/lib/Types.cpp
49

i think this might read better as:

OS << R.RT << " reference to " << R.Target << "@0x" << ...;
This revision is now accepted and ready to land.Dec 12 2022, 5:42 AM
This revision was landed with ongoing or failed builds.Dec 12 2022, 5:52 AM
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.