This is an archive of the discontinued LLVM Phabricator instance.

Differential D138801

[libc++] Remove CMake workaround for the discontinued Projects build
ClosedPublic

Authored by ldionne on Nov 28 2022, 5:53 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG609b95cea16e: [libc++] Remove CMake workaround for the discontinued Projects build

Diff Detail

Event Timeline

ldionne created this revision.Nov 28 2022, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 5:53 AM
ldionne requested review of this revision.Nov 28 2022, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 5:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B199736: Diff 478209.Nov 28 2022, 7:46 AM
ldionne accepted this revision.Nov 28 2022, 8:10 AM
This revision is now accepted and ready to land.Nov 28 2022, 8:10 AM
Closed by commit rG609b95cea16e: [libc++] Remove CMake workaround for the discontinued Projects build (authored by ldionne). · Explain WhyNov 28 2022, 8:11 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG609b95cea16e: [libc++] Remove CMake workaround for the discontinued Projects build.

Revision Contents

PathSize
libcxx/
6 lines

Diff 478248

libcxx/CMakeLists.txt

Show First 20 Lines • Show All 488 Lines • ▼ Show 20 Lines
endif() endif()
#=============================================================================== #===============================================================================
# Setup Compiler Flags # Setup Compiler Flags
#=============================================================================== #===============================================================================
include(HandleLibCXXABI) # Setup the ABI library flags include(HandleLibCXXABI) # Setup the ABI library flags
# Remove flags that may have snuck in.
# TODO: This shouldn't be necessary anymore since we don't support the Project
# build anymore, so the rest of LLVM can't pollute our flags.
remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG -lc++abi)
remove_flags(--stdlib=libc++ -stdlib=libc++ --stdlib=libstdc++ -stdlib=libstdc++)
# FIXME: Remove all debug flags and flags that change which Windows # FIXME: Remove all debug flags and flags that change which Windows
# default libraries are linked. Currently we only support linking the # default libraries are linked. Currently we only support linking the
# non-debug DLLs # non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md") remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md")
# FIXME(EricWF): See the FIXME on LIBCXX_ENABLE_PEDANTIC. # FIXME(EricWF): See the FIXME on LIBCXX_ENABLE_PEDANTIC.
# Remove the -pedantic flag and -Wno-pedantic and -pedantic-errors # Remove the -pedantic flag and -Wno-pedantic and -pedantic-errors
# so they don't get transformed into -Wno and -errors respectively. # so they don't get transformed into -Wno and -errors respectively.
▲ Show 20 Lines • Show All 438 Lines • Show Last 20 Lines