This is an archive of the discontinued LLVM Phabricator instance.

Differential D138438

[libc++] Don't workaround GCC issue on non-GCC compilers
ClosedPublic

Authored by ldionne on Nov 21 2022, 8:04 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG4548fca74272: [libc++] Don't workaround GCC issue on non-GCC compilers

Diff Detail

Event Timeline

ldionne created this revision.Nov 21 2022, 8:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 8:04 AM
ldionne requested review of this revision.Nov 21 2022, 8:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2022, 8:04 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B198797: Diff 476909.Nov 21 2022, 10:02 AM
ldionne updated this revision to Diff 476947.Nov 21 2022, 10:41 AM

Trigger CI

ldionne accepted this revision.Nov 21 2022, 1:08 PM
This revision is now accepted and ready to land.Nov 21 2022, 1:08 PM
This revision was landed with ongoing or failed builds.Nov 21 2022, 1:09 PM
Closed by commit rG4548fca74272: [libc++] Don't workaround GCC issue on non-GCC compilers (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG4548fca74272: [libc++] Don't workaround GCC issue on non-GCC compilers.
Harbormaster completed remote builds in B198823: Diff 476947.Nov 21 2022, 10:29 PM

Revision Contents

PathSize
libcxx/
include/
16 lines

Diff 476983

libcxx/include/limits.h

Show All 37 Lines
*/ */
#include <__config> #include <__config>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#ifndef __GNUC__ #ifdef _LIBCPP_COMPILER_GCC
# if __has_include_next(<limits.h>)
# include_next <limits.h>
# endif
#else
// GCC header limits.h recursively includes itself through another header called // GCC header limits.h recursively includes itself through another header called
// syslimits.h for some reason. This setup breaks down if we directly // syslimits.h for some reason. This setup breaks down if we directly
// #include_next GCC's limits.h (reasons not entirely clear to me). // #include_next GCC's limits.h (reasons not entirely clear to me).
// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107795 for more details. // See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107795 for more details.
// Therefore, we manually re-create the necessary include sequence below: // Therefore, we manually re-create the necessary include sequence below:
// Get the system limits.h defines (force recurse into the next level) // Get the system limits.h defines (force recurse into the next level)
#define _GCC_LIMITS_H_ #define _GCC_LIMITS_H_
#define _GCC_NEXT_LIMITS_H #define _GCC_NEXT_LIMITS_H
#include_next <limits.h> #include_next <limits.h>
// Get the ISO C defines // Get the ISO C defines
#undef _GCC_LIMITS_H_ #undef _GCC_LIMITS_H_
#include_next <limits.h> #include_next <limits.h>
#endif // __GNUC__
#else
# if __has_include_next(<limits.h>)
# include_next <limits.h>
# endif
#endif // _LIBCPP_COMPILER_GCC
#endif // _LIBCPP_LIMITS_H #endif // _LIBCPP_LIMITS_H