Page MenuHomePhabricator
Differential D138384

[libc++] Remove libc++'s own <limits.h>
Needs ReviewPublic
Actions

Authored by ldionne on Nov 20 2022, 10:57 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

We do not define anything beyond the C Library's limits.h, so it
shouldn't be needed. This removes the need for a GCC-specific
workaround, see [1].

[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107795

Diff Detail

Event Timeline

ldionne created this revision.Nov 20 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2022, 10:57 AM
ldionne requested review of this revision.Nov 20 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2022, 10:57 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B198690: Diff 476764.Nov 20 2022, 11:15 AM
ldionne added a comment.Nov 21 2022, 8:02 AM

Blocked on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107795.

ldionne updated this revision to Diff 480089.Dec 5 2022, 6:24 AM
ldionne retitled this revision from [libc++] Remove workaround for limits.h on GCC to [libc++] Remove libc++'s own <limits.h>.
ldionne edited the summary of this revision. (Show Details)

Remove limits.h instead.

Harbormaster completed remote builds in B201103: Diff 480089.Dec 5 2022, 6:29 AM
ldionne updated this revision to Diff 480096.Dec 5 2022, 7:00 AM

Remove stray limits.h from CMake header list

Harbormaster completed remote builds in B201110: Diff 480096.Dec 5 2022, 8:03 AM

Revision Contents
Changeset List

Diff 480096

View Options

libcxx/include/CMakeLists.txt

Loading...
View Options

libcxx/include/limits.h

Loading...
View Options

libcxx/include/module.modulemap.in

Loading...
View Options

libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp

Loading...
View Options

libcxx/test/libcxx/clang_tidy.sh.cpp

Loading...
View Options

libcxx/test/libcxx/double_include.sh.cpp

Loading...
View Options

libcxx/test/libcxx/min_max_macros.compile.pass.cpp

Loading...
View Options

libcxx/test/libcxx/modules_include.sh.cpp

Loading...
View Options

libcxx/test/libcxx/nasty_macros.compile.pass.cpp

Loading...
View Options

libcxx/test/libcxx/no_assert_include.compile.pass.cpp

Loading...
View Options

libcxx/test/libcxx/transitive_includes.sh.cpp

Loading...