This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove libc++'s own <limits.h>
AbandonedPublic

Authored by ldionne on Nov 20 2022, 10:57 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGf90125434159: [libc++] Remove libc++'s own <limits.h> (#65472)
Summary

We do not define anything beyond the C Library's limits.h, so it
shouldn't be needed. This removes the need for a GCC-specific
workaround, see [1].

[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107795

Diff Detail

Event Timeline

ldionne created this revision.Nov 20 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2022, 10:57 AM
ldionne requested review of this revision.Nov 20 2022, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2022, 10:57 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 480089.Dec 5 2022, 6:24 AM
ldionne retitled this revision from [libc++] Remove workaround for limits.h on GCC to [libc++] Remove libc++'s own <limits.h>.
ldionne edited the summary of this revision. (Show Details)

Remove limits.h instead.

ldionne updated this revision to Diff 480096.Dec 5 2022, 7:00 AM

Remove stray limits.h from CMake header list

ldionne abandoned this revision.Sep 6 2023, 6:15 AM

[Github PR transition cleanup]

Closing, moved to https://github.com/llvm/llvm-project/pull/65472.

libcxx/include/CMakeLists.txt