[BOLT] Leverage annotated_builder in NFC builder

[Amir]

Summary

Remove custom code and leverage existing annotated_builder functionality.

[Amir]

D139694 supersedes this diff

zorg/buildbot/builders/annotated/bolt-nfc.py

 #!/usr/bin/python3
 
 import os
 import subprocess
 import sys
 import traceback
 import util
 from contextlib import contextmanager
+import annotated_builder
 
-def main():
+def main(argv):
+    ap = annotated_builder.get_argument_parser()
+    args = ap.parse_args(argv[1:])
     source_dir = os.path.join('..', 'llvm-project')
     tests_dir = os.path.join('..', 'bolt-tests')
 
-    with step('fetch large-bolt-tests'):
-        if os.path.exists(tests_dir):
-            run_command(['git', '-C', tests_dir, 'fetch', 'origin'])
-            run_command(['git', '-C', tests_dir, 'reset', '--hard',
-                         'origin/main'])
-        else:
-            run_command(['git', 'clone',
-                         'https://github.com/rafaelauler/bolt-tests',
-                         tests_dir])
-
-    with step('cmake'):
-        cmake_args = ['-GNinja',
-                      '-DCMAKE_BUILD_TYPE=Release',
-                      '-DLLVM_APPEND_VC_REV=OFF',
-                      '-DLLVM_CCACHE_BUILD=ON',
-                      '-DLLVM_ENABLE_ASSERTIONS=ON',
-                      '-DLLVM_ENABLE_LLD=ON',
-                      '-DLLVM_ENABLE_PROJECTS=clang;lld;bolt',
-                      '-DLLVM_TARGETS_TO_BUILD=X86;AArch64',
-                      '-DLLVM_EXTERNAL_PROJECTS=bolttests',
-                      '-DLLVM_EXTERNAL_BOLTTESTS_SOURCE_DIR='+tests_dir,
-                      ]
+    projects = ['llvm', 'clang', 'lld', 'bolt']
+    extra_cmake_args = [
+    check_targets = [
+        'check-bolt',
+        'check-large-bolt',
+    ]
 
-        util.clean_dir('.')
-        run_command(['cmake', os.path.join(source_dir, 'llvm')] + cmake_args)
-
-    with step('build bolt'):
-        run_command(['ninja', 'bolt'])
-
-    with step('check-bolt'):
-        run_command(['ninja', 'check-bolt'])
+    with step('fetch large-bolt-tests'):
+        if os.path.exists(tests_dir):
+            run_command(['git', '-C', tests_dir, 'fetch', 'origin'])
+            run_command(['git', '-C', tests_dir, 'reset', '--hard',
+                         'origin/main'])
+        else:
+            run_command(['git', 'clone',
+                         'https://github.com/rafaelauler/bolt-tests',
+                         tests_dir])
 
-    with step('check-large-bolt'):
-        run_command(['ninja', 'check-large-bolt'])
+    builder = annotated_builder.AnnotatedBuilder()
+    builder.run_steps(projects=projects,
+                      extra_cmake_args=extra_cmake_args,
+                      check_targets=check_targets,
+                      jobs=args.jobs)
 
     with step('nfc-check-setup'):
         run_command([os.path.join(source_dir, 'bolt', 'utils',
             'nfc-check-setup.py')])
 
     with step('nfc-check-bolt', warn_on_fail=True, halt_on_fail=False):
         run_command([os.path.join('bin', 'llvm-lit'), '-sv', '-j2',
             # bolt-info will always mismatch in NFC mode
             '--xfail=bolt-info.test',
+            # FIXME[aaupov]: https://github.com/llvm/llvm-project/issues/59008
+            '--filter-out=X86/bb-with-two-tail-calls.s',
             'tools/bolt/test'])
 
     with step('nfc-check-large-bolt', warn_on_fail=True, halt_on_fail=False):
         run_command([os.path.join('bin', 'llvm-lit'), '-sv', '-j2',
             'tools/bolttests'])
 
 
 @contextmanager