This is an archive of the discontinued LLVM Phabricator instance.

Differential D137916

[cmake] Disable RTTI by default for tests
AbandonedPublic

Authored by Trass3r on Nov 13 2022, 3:08 PM.

Details

Reviewers
None

Diff Detail

Event Timeline

Trass3r created this revision.Nov 13 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2022, 3:08 PM
Trass3r requested review of this revision.Nov 13 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2022, 3:08 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Trass3r added inline comments.Nov 13 2022, 3:12 PM
third-party/unittest/CMakeLists.txt
33–34

I think this is a remnant of https://github.com/llvm/llvm-project/commit/889c1e7d80958377f1e2871d5fea7ddd785130b6#diff-b89c70e6ef87ab9d76345be2bb5e3a8857ba575b94963e07e91659f9fc61dcaa and could even be completely removed?

Harbormaster completed remote builds in B197438: Diff 475021.Nov 13 2022, 3:30 PM
Trass3r updated this revision to Diff 475111.Nov 14 2022, 5:06 AM
Trass3r retitled this revision from [cmake] Disable RTTI for tests to [cmake] Disable RTTI by default for tests.

fix build error

Harbormaster completed remote builds in B197505: Diff 475111.Nov 14 2022, 6:00 AM
Trass3r abandoned this revision.Nov 14 2022, 8:26 AM

Revision Contents

PathSize
third-party/
unittest/
5 lines

Diff 475111

third-party/unittest/CMakeLists.txt

Show All 24 Linesif(SUPPORTS_VARIADIC_MACROS_FLAG)
add_definitions("-Wno-variadic-macros") add_definitions("-Wno-variadic-macros")
endif() endif()
if(SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG) if(SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG)
add_definitions("-Wno-gnu-zero-variadic-macro-arguments") add_definitions("-Wno-gnu-zero-variadic-macro-arguments")
endif() endif()
if(CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG) if(CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG)
add_definitions("-Wno-covered-switch-default") add_definitions("-Wno-covered-switch-default")
endif() endif()
set(LLVM_REQUIRES_RTTI 1)
add_definitions( -DGTEST_HAS_RTTI=0 )
if (HAVE_LIBPTHREAD) if (HAVE_LIBPTHREAD)
Trass3rAuthorUnsubmitted
Done
ReplyInline Actions

I think this is a remnant of https://github.com/llvm/llvm-project/commit/889c1e7d80958377f1e2871d5fea7ddd785130b6#diff-b89c70e6ef87ab9d76345be2bb5e3a8857ba575b94963e07e91659f9fc61dcaa and could even be completely removed?

Trass3r: I think this is a remnant of https://github.com/llvm/llvm…
list(APPEND LIBS pthread) list(APPEND LIBS pthread)
endif() endif()
add_llvm_library(llvm_gtest add_llvm_library(llvm_gtest
googletest/src/gtest-all.cc googletest/src/gtest-all.cc
googlemock/src/gmock-all.cc googlemock/src/gmock-all.cc
LINK_LIBS LINK_LIBS
Show All 9 Lines
# The googletest and googlemock sources don't presently use the 'override' # The googletest and googlemock sources don't presently use the 'override'
# keyword, which leads to lots of warnings from -Wsuggest-override. Disable # keyword, which leads to lots of warnings from -Wsuggest-override. Disable
# that warning here for any targets that link to gtest. # that warning here for any targets that link to gtest.
if(CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG) if(CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
add_definitions("-Wno-suggest-override") add_definitions("-Wno-suggest-override")
set_target_properties(llvm_gtest PROPERTIES INTERFACE_COMPILE_OPTIONS "-Wno-suggest-override") set_target_properties(llvm_gtest PROPERTIES INTERFACE_COMPILE_OPTIONS "-Wno-suggest-override")
endif() endif()
target_compile_definitions(llvm_gtest PUBLIC GTEST_HAS_RTTI=0)
if (NOT LLVM_ENABLE_THREADS) if (NOT LLVM_ENABLE_THREADS)
target_compile_definitions(llvm_gtest PUBLIC GTEST_HAS_PTHREAD=0) target_compile_definitions(llvm_gtest PUBLIC GTEST_HAS_PTHREAD=0)
endif () endif ()
target_include_directories(llvm_gtest target_include_directories(llvm_gtest
PUBLIC googletest/include googlemock/include PUBLIC googletest/include googlemock/include
PRIVATE googletest googlemock PRIVATE googletest googlemock
) )
Show All 22 Lines