This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Set 4-byte alignment for `__init_offsets`
ClosedPublic

Authored by BertalanD on Nov 10 2022, 1:50 PM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rG948fc66f5e86: [lld-macho] Set 4-byte alignment for `__init_offsets`
Summary

dyld refuses to run initializers if this section is not aligned.

Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=1383240

Diff Detail

Event Timeline

BertalanD created this revision.Nov 10 2022, 1:50 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 10 2022, 1:50 PM
BertalanD requested review of this revision.Nov 10 2022, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2022, 1:50 PM
int3 accepted this revision.Nov 10 2022, 1:53 PM
int3 added a subscriber: int3.

lgtm

This revision is now accepted and ready to land.Nov 10 2022, 1:53 PM
This revision was automatically updated to reflect the committed changes.