Page MenuHomePhabricator

Add new linux worker and a legacy linux gcc build that we do internally
AcceptedPublic

Authored by dyung on Nov 4 2022, 3:11 AM.

Details

Reviewers
gkistanova
Summary

This change adds a new linux worker and adds a build configuration that matches one we run internally. Our internal buildbot was setup a while ago on Ubuntu 18 which contains GCC 7.5 which is still supported, but due to it's age, sometimes does fail, so it would be good to have a public buildbot which mirrors our internal buildbot configuration so that these problems can be found more quickly.

Diff Detail

Event Timeline

dyung created this revision.Nov 4 2022, 3:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 3:11 AM
dyung requested review of this revision.Nov 4 2022, 3:11 AM

Thanks, Douglas!

The patch itself looks good.

Could you re-phrase the title and the description, please? Explaining the purpose of the new build configuration without referencing “ our internal build bot”, which people are not necessarily familiar, will be great.

dyung retitled this revision from Add new linux worker and an upstream version of our internal build bot to Add new linux worker and a legacy linux gcc build that we do internally.Nov 8 2022, 12:27 PM
dyung edited the summary of this revision. (Show Details)

Thanks, Douglas!

The patch itself looks good.

Could you re-phrase the title and the description, please? Explaining the purpose of the new build configuration without referencing “ our internal build bot”, which people are not necessarily familiar, will be great.

Thanks, I've updated the title and description so hopefully it is a better now, but let me know if it could still be clarified further!

This revision is now accepted and ready to land.Nov 8 2022, 5:38 PM