This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Improves modular build.
ClosedPublic

Authored by Mordante on Oct 25 2022, 12:58 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGddcb2d19b372: [libc++] Improves modular build.
Summary

Makes sure headers having a xxx_result as return type export the proper
header. Without exporting these modularized headers are not self
contained.

This is related to D136045.

Diff Detail

Event Timeline

Mordante created this revision.Oct 25 2022, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 12:58 PM
Mordante requested review of this revision.Oct 25 2022, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 12:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Nov 1 2022, 11:42 AM
ldionne added a subscriber: ldionne.

Per live discussion, these issues were found in one of @Mordante 's WIP patch for format/ranges support. Hence, this would trigger errors with our existing tests, and no additional testing is really necessary.

libcxx/include/__format/formatter_output.h
1

Not attached: there's a typo in the commit message Makes sure headers having a xxx_resul as return type export the proper.

This revision is now accepted and ready to land.Nov 1 2022, 11:42 AM
Mordante edited the summary of this revision. (Show Details)Nov 1 2022, 12:23 PM
Mordante marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.