This is an archive of the discontinued LLVM Phabricator instance.

Differential D136600

[lldb-tests] Force use of system stdlib for Objective-C test
ClosedPublic

Authored by fdeazeve on Oct 24 2022, 7:31 AM.

Details

Reviewers
aprantl
Michael137
JDevlieghere
Commits
rGc413df064e85: [lldb-tests] Force use of system stdlib for Objective-C test
Summary

The test TestObjCDirectMethods loads the Objective C runtime, which
doesn't work well with custom a libcxx, resulting in two copies of the
standard library to be loaded at runtime. Like what was done for
TestObjCExceptions, this commit forces the usage of the system's
library instead. The minimum required Clang version is set to the oldest
Clang that can compile the libraries available in the lldb-matrix bots.

Diff Detail

Event Timeline

fdeazeve created this revision.Oct 24 2022, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 7:31 AM
fdeazeve requested review of this revision.Oct 24 2022, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2022, 7:31 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
fdeazeve updated this revision to Diff 470146.Oct 24 2022, 7:32 AM

Edit commit message

Herald added a subscriber: JDevlieghere. · View Herald TranscriptOct 24 2022, 7:32 AM
Harbormaster completed remote builds in B193932: Diff 470146.Oct 24 2022, 7:36 AM
Michael137 accepted this revision.Oct 24 2022, 7:39 AM
Michael137 added a subscriber: Michael137.

LGTM

This revision is now accepted and ready to land.Oct 24 2022, 7:39 AM
JDevlieghere accepted this revision.Oct 24 2022, 8:53 AM
Closed by commit rGc413df064e85: [lldb-tests] Force use of system stdlib for Objective-C test (authored by fdeazeve). · Explain WhyOct 24 2022, 9:40 AM
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rGc413df064e85: [lldb-tests] Force use of system stdlib for Objective-C test.

Revision Contents

PathSize
lldb/
test/
API/
lang/
objc/
objc_direct-methods/
1 line
4 lines

Diff 470188

lldb/test/API/lang/objc/objc_direct-methods/Makefile

OBJC_SOURCES := main.m OBJC_SOURCES := main.m
LD_EXTRAS := -lobjc -framework Foundation LD_EXTRAS := -lobjc -framework Foundation
USE_SYSTEM_STDLIB := 1
include Makefile.rules include Makefile.rules

lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py

from lldbsuite.test import lldbinline from lldbsuite.test import lldbinline
from lldbsuite.test import decorators
decor = [decorators.skipIf(compiler="clang", compiler_version=['<', '13.0'])]
lldbinline.MakeInlineTest( lldbinline.MakeInlineTest(
__file__, globals(), []) __file__, globals(), decor)