This is an archive of the discontinued LLVM Phabricator instance.

[Bugpoint] Allow fallback to clang
ClosedPublic

Authored by davide on Oct 11 2015, 5:27 PM.

Details

Summary

FreeBSD doesn't ship with gcc by default anymore, so some bugpoint tests fail on a stock installation.
In D12273 I proposed to XFAIL the tests on FreeBSD, but Hal replied proposing to fallback on clang if gcc is not available.
This patch implements the proposed logic. Hal, I listed you as reviewer because you're the one that came up with this idea and apparently Bugpoint is currently unowned. Feel free to remove yourself and/or suggest somebody else that should review this.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 37076.Oct 11 2015, 5:27 PM
davide retitled this revision from to [Bugpoint] Allow fallback to clang.
davide updated this object.
davide added a reviewer: hfinkel.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: llvm-commits.

Changing GCCBinary in here looks odd. It would be particularly odd if the --gcc option was given.

How about changing the default of the option to "" and in main setting it to "gcc" or "clang" if the user didn't pass -gcc?

davide updated this revision to Diff 37305.Oct 13 2015, 5:48 PM
davide removed rL LLVM as the repository for this revision.

I think your idea is much better, thanks.

This revision was automatically updated to reflect the committed changes.