Page MenuHomePhabricator

Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows
ClosedPublic

Authored by enlight on Oct 11 2015, 8:57 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

enlight updated this revision to Diff 37056.Oct 11 2015, 8:57 AM
enlight retitled this revision from to Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows.
enlight updated this object.
enlight added reviewers: zturner, clayborg.
enlight set the repository for this revision to rL LLVM.
enlight added a subscriber: lldb-commits.
enlight added a comment.EditedOct 11 2015, 9:23 AM

Zach,

I've looked at the path separator issue you've mentioned earlier in D13201, and I think it's fine as is. All those paths with the forward slashes end up in a FileSpec, which converts forward slashes to backward slashes before passing them through to any Win32 APIs, and FileSpec::GetPath() also converts slashes by default.

zturner edited edge metadata.Oct 11 2015, 9:34 AM
zturner added a subscriber: zturner.

Ok, sounds good then. Thanks for checking

clayborg accepted this revision.Oct 12 2015, 9:52 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2015, 9:52 AM
This revision was automatically updated to reflect the committed changes.